about summary refs log tree commit diff
path: root/sysdeps
diff options
context:
space:
mode:
authorLeandro Pereira <leandro.pereira@microsoft.com>2019-10-02 12:48:17 -0400
committerCarlos O'Donell <carlos@redhat.com>2019-10-18 15:55:33 -0400
commit95c1056962a3f2297c94ce47f0eaf0c5b6563231 (patch)
tree8e6566200a6a17bea0a7d0eb8285b83a248e973e /sysdeps
parentfed33b0fb03d1942a6713286176d42869c0f1580 (diff)
downloadglibc-95c1056962a3f2297c94ce47f0eaf0c5b6563231.tar.gz
glibc-95c1056962a3f2297c94ce47f0eaf0c5b6563231.tar.xz
glibc-95c1056962a3f2297c94ce47f0eaf0c5b6563231.zip
elf: Use nocancel pread64() instead of lseek()+read()
Transforms this, when linking in a shared object:

  openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
  read(3, "\177ELF\2\1\1\3"..., 832) = 832
  lseek(3, 792, SEEK_SET)           = 792
  read(3, "\4\0\0\0\24\0\0\0"..., 68) = 68
  fstat(3, {st_mode=S_IFREG|0755, st_size=6699224, ...}) = 0
  lseek(3, 792, SEEK_SET)           = 792
  read(3, "\4\0\0\0\24\0\0\0"..., 68) = 68
  lseek(3, 864, SEEK_SET)           = 864
  read(3, "\4\0\0\0\20\0\0\0"..., 32) = 32

Into this:

  openat(AT_FDCWD, "/lib64/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
  read(3, "\177ELF\2\1\1\3"..., 832) = 832
  pread(3, "\4\0\0\0\24\0\0\0"..., 68, 792) = 68
  fstat(3, {st_mode=S_IFREG|0755, st_size=6699224, ...}) = 0
  pread(3, "\4\0\0\0\24\0\0\0"..., 68, 792) = 68
  pread(3, "\4\0\0\0\20\0\0\0"..., 32, 864) = 32

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'sysdeps')
-rw-r--r--sysdeps/x86/dl-prop.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/sysdeps/x86/dl-prop.h b/sysdeps/x86/dl-prop.h
index a99eec11b9..fa5bd988ca 100644
--- a/sysdeps/x86/dl-prop.h
+++ b/sysdeps/x86/dl-prop.h
@@ -167,8 +167,7 @@ _dl_process_pt_note (struct link_map *l, const ElfW(Phdr) *ph,
 	  note_malloced = malloc (size);
 	  note = note_malloced;
 	}
-      __lseek (fd, ph->p_offset, SEEK_SET);
-      if (__read_nocancel (fd, (void *) note, size) != size)
+      if (__pread64_nocancel (fd, (void *) note, size, ph->p_offset) != size)
 	{
 	  if (note_malloced)
 	    free (note_malloced);