diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-08-10 21:01:08 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-08-10 21:01:08 +0000 |
| commit | 5220a1aa8da8f9fc6163f67164d3889effb9621c (patch) | |
| tree | 62541d52ee8a85c5ca35829ec7e301d36ba15e72 /sysdeps | |
| parent | 71b67af1ffa57a0322ac1bd77141060fffc4b4e4 (diff) | |
| download | glibc-5220a1aa8da8f9fc6163f67164d3889effb9621c.tar.gz glibc-5220a1aa8da8f9fc6163f67164d3889effb9621c.tar.xz glibc-5220a1aa8da8f9fc6163f67164d3889effb9621c.zip | |
Add tests for fegetexceptflag, fesetexceptflag.
I noticed that there was no meaningful test coverage for fegetexceptflag and fesetexceptflag (one test ensures that calls to them compile and link, but nothing to verify they work correctly). This patch adds tests for these functions. fesetexceptflag is meant to set the relevant exception flag bits to the saved state without causing enabled traps to be taken. On some architectures, it is not possible to set exception flag bits without causing enabled traps to occur. Such architectures need to define EXCEPTION_SET_FORCES_TRAP to 1 in their math-tests.h, as is done in this patch for powerpc. x86 avoids needing to define this because the traps resulting from setting exception bits don't occur until the next floating-point operation or fwait instruction. Tested for x86_64, x86 and powerpc. Note that test-fexcept fails for powerpc because of a pre-existing bug in fesetexceptflag for powerpc, which I'll fix separately. * math/test-fexcept-traps.c: New file. * math/test-fexcept.c: Likewise. * math/Makefile (tests): Add test-fexcept and test-fexcept-traps. * sysdeps/generic/math-tests.h (EXCEPTION_SET_FORCES_TRAP): New macro. * sysdeps/powerpc/math-tests.h [!__NO_FPRS__] (EXCEPTION_SET_FORCES_TRAP): Likewise.
Diffstat (limited to 'sysdeps')
| -rw-r--r-- | sysdeps/generic/math-tests.h | 9 | ||||
| -rw-r--r-- | sysdeps/powerpc/math-tests.h | 6 |
2 files changed, 15 insertions, 0 deletions
diff --git a/sysdeps/generic/math-tests.h b/sysdeps/generic/math-tests.h index 9393229a36..974dda403a 100644 --- a/sysdeps/generic/math-tests.h +++ b/sysdeps/generic/math-tests.h @@ -87,3 +87,12 @@ # define EXCEPTION_ENABLE_SUPPORTED(EXCEPT) \ (EXCEPTION_TESTS_float || EXCEPTION_TESTS_double) #endif + +/* Indicate whether exception traps, if enabled, occur whenever an + exception flag is set explicitly, so it is not possible to set flag + bits with traps enabled without causing traps to be taken. If + traps cannot be enabled, the value of this macro does not + matter. */ +#ifndef EXCEPTION_SET_FORCES_TRAP +# define EXCEPTION_SET_FORCES_TRAP 0 +#endif diff --git a/sysdeps/powerpc/math-tests.h b/sysdeps/powerpc/math-tests.h index 31042fa5b6..426a02717d 100644 --- a/sysdeps/powerpc/math-tests.h +++ b/sysdeps/powerpc/math-tests.h @@ -24,4 +24,10 @@ <http://gcc.gnu.org/PR56828>. */ #define SNAN_TESTS_TYPE_CAST 0 +#ifndef __NO_FPRS__ +/* Setting exception flags in FPSCR results in enabled traps for those + exceptions being taken. */ +# define EXCEPTION_SET_FORCES_TRAP 1 +#endif + #include_next <math-tests.h> |