about summary refs log tree commit diff
path: root/sysdeps
diff options
context:
space:
mode:
authorAurelien Jarno <aurelien@aurel32.net>2021-12-14 22:44:35 +0100
committerAurelien Jarno <aurelien@aurel32.net>2021-12-17 20:29:32 +0100
commitd2e594d71509faf36cf851a69370db34a4f5fa65 (patch)
tree38899de60ef55a647615dac7419876b4acf8f68a /sysdeps
parent94058f6cde8b887178885954740ac6c866d25eab (diff)
downloadglibc-d2e594d71509faf36cf851a69370db34a4f5fa65.tar.gz
glibc-d2e594d71509faf36cf851a69370db34a4f5fa65.tar.xz
glibc-d2e594d71509faf36cf851a69370db34a4f5fa65.zip
riscv: align stack in clone [BZ #28702]
The RISC-V ABI [1] mandates that "the stack pointer shall be aligned to
a 128-bit boundary upon procedure entry". This as not the case in clone.

This fixes the misc/tst-misalign-clone-internal and
misc/tst-misalign-clone tests.

Fixes bug 28702.

[1] https://github.com/riscv-non-isa/riscv-elf-psabi-doc
Diffstat (limited to 'sysdeps')
-rw-r--r--sysdeps/unix/sysv/linux/riscv/clone.S3
1 files changed, 3 insertions, 0 deletions
diff --git a/sysdeps/unix/sysv/linux/riscv/clone.S b/sysdeps/unix/sysv/linux/riscv/clone.S
index 12f91a20d3..161e83c7e3 100644
--- a/sysdeps/unix/sysv/linux/riscv/clone.S
+++ b/sysdeps/unix/sysv/linux/riscv/clone.S
@@ -32,6 +32,9 @@
 	.text
 LEAF (__clone)
 
+	/* Align stack to a 128-bit boundary as per RISC-V ABI.  */
+	andi		a1,a1,ALMASK
+
 	/* Sanity check arguments.  */
 	beqz		a0,L (invalid)	/* No NULL function pointers.  */
 	beqz		a1,L (invalid)	/* No NULL stack pointers.  */