about summary refs log tree commit diff
path: root/sysdeps/x86_64/strcasecmp_l.S
diff options
context:
space:
mode:
authorNoah Goldstein <goldstein.w.n@gmail.com>2022-07-13 16:32:59 -0700
committerNoah Goldstein <goldstein.w.n@gmail.com>2022-07-16 03:07:59 -0700
commitceabdcd130ca7043b0fcf2676183d79431d10493 (patch)
treef6ced435023b66ac1f3b519e5b26a60ef8f479dd /sysdeps/x86_64/strcasecmp_l.S
parentc353689e49e72f3aafa1a9e68d4f7a4f33a79cbe (diff)
downloadglibc-ceabdcd130ca7043b0fcf2676183d79431d10493.tar.gz
glibc-ceabdcd130ca7043b0fcf2676183d79431d10493.tar.xz
glibc-ceabdcd130ca7043b0fcf2676183d79431d10493.zip
x86: Add support to build strcmp/strlen/strchr with explicit ISA level
1. Add default ISA level selection in non-multiarch/rtld
   implementations.

2. Add ISA level build guards to different implementations.
    - I.e strcmp-avx2.S which is ISA level 3 will only build if
      compiled ISA level <= 3. Otherwise there is no reason to
      include it as we will always use one of the ISA level 4
      implementations (strcmp-evex.S).

3. Refactor the ifunc selector and ifunc implementation list to use
   the ISA level aware wrapper macros that allow functions below the
   compiled ISA level (with a guranteed replacement) to be skipped.

Tested with and without multiarch on x86_64 for ISA levels:
{generic, x86-64-v2, x86-64-v3, x86-64-v4}

And m32 with and without multiarch.
Diffstat (limited to 'sysdeps/x86_64/strcasecmp_l.S')
-rw-r--r--sysdeps/x86_64/strcasecmp_l.S32
1 files changed, 28 insertions, 4 deletions
diff --git a/sysdeps/x86_64/strcasecmp_l.S b/sysdeps/x86_64/strcasecmp_l.S
index 84fd7fdfd3..5afa7ea098 100644
--- a/sysdeps/x86_64/strcasecmp_l.S
+++ b/sysdeps/x86_64/strcasecmp_l.S
@@ -1,11 +1,35 @@
+/* strcasecmp_l dispatch for RTLD and non-multiarch build
+   Copyright (C) 2022 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <https://www.gnu.org/licenses/>.  */
+
 /* Symbols = __strcasecmp_l and __strcasecmp.  */
 
-#include "multiarch/strcasecmp_l-sse2.S"
+#define DEFAULT_IMPL_V1	"multiarch/strcasecmp_l-sse2.S"
+/* This may cause regressions on some processors that heavily prefer
+   aligned loads or have slow a implementation of the `pcmpstri`
+   instruction.  */
+#define DEFAULT_IMPL_V2	"multiarch/strcasecmp_l-sse4_2.S"
+#define DEFAULT_IMPL_V3	"multiarch/strcasecmp_l-avx2.S"
+#define DEFAULT_IMPL_V4	"multiarch/strcasecmp_l-evex.S"
 
-libc_hidden_builtin_def (__strcasecmp_l)
+#include "isa-default-impl.h"
 
+libc_hidden_def (__strcasecmp_l)
 weak_alias (__strcasecmp_l, strcasecmp_l)
-libc_hidden_def (strcasecmp_l)
 
-weak_alias (__strcasecmp, strcasecmp)
 libc_hidden_def (__strcasecmp)
+weak_alias (__strcasecmp, strcasecmp)