diff options
| author | Fangrui Song <maskray@google.com> | 2021-07-08 14:26:22 -0700 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2021-07-08 14:26:22 -0700 |
| commit | 115d242456de158e698ffb0f9a5fee3118e9e825 (patch) | |
| tree | aa9d3aa72fb7c960e0f77fba1ae6f4c494a58312 /sysdeps/x86_64/configure | |
| parent | bba4383c6b4db09c84c7a194b5e80978e6c44ee5 (diff) | |
| download | glibc-115d242456de158e698ffb0f9a5fee3118e9e825.tar.gz glibc-115d242456de158e698ffb0f9a5fee3118e9e825.tar.xz glibc-115d242456de158e698ffb0f9a5fee3118e9e825.zip | |
x86_64: Remove unneeded static PIE check for undefined weak diagnostic
https://sourceware.org/bugzilla/show_bug.cgi?id=21782 dropped an ld diagnostic for R_X86_64_PC32 referencing an undefined weak symbol in -pie links. Arguably keeping the diagnostic like other ports is more correct, since statically resolving movl foo(%rip), %eax to the link-time zero address produces a corrupted output. It turns out that --enable-static-pie builds do not depend on the ld behavior. GCC generates GOT indirection for weak declarations for -fPIE/-fPIC, so what ld does with the PC-relative relocation doesn't really matter. Reviewed-by: H.J. Lu <hjl.tools@gmail.com>
Diffstat (limited to 'sysdeps/x86_64/configure')
| -rwxr-xr-x[-rw-r--r--] | sysdeps/x86_64/configure | 33 |
1 files changed, 0 insertions, 33 deletions
diff --git a/sysdeps/x86_64/configure b/sysdeps/x86_64/configure index 198554d788..75c96d60d4 100644..100755 --- a/sysdeps/x86_64/configure +++ b/sysdeps/x86_64/configure @@ -107,39 +107,6 @@ if test x"$build_mathvec" = xnotset; then build_mathvec=yes fi -if test "$static_pie" = yes; then - { $as_echo "$as_me:${as_lineno-$LINENO}: checking for linker static PIE support" >&5 -$as_echo_n "checking for linker static PIE support... " >&6; } -if ${libc_cv_ld_static_pie+:} false; then : - $as_echo_n "(cached) " >&6 -else - cat > conftest.s <<\EOF - .text - .global _start - .weak foo -_start: - leaq foo(%rip), %rax -EOF - libc_cv_pie_option="-Wl,-pie" - if { ac_try='${CC-cc} $CFLAGS $CPPFLAGS $LDFLAGS -nostartfiles -nostdlib $no_ssp $libc_cv_pie_option -o conftest conftest.s 1>&5' - { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5 - (eval $ac_try) 2>&5 - ac_status=$? - $as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5 - test $ac_status = 0; }; }; then - libc_cv_ld_static_pie=yes - else - libc_cv_ld_static_pie=no - fi -rm -f conftest* -fi -{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $libc_cv_ld_static_pie" >&5 -$as_echo "$libc_cv_ld_static_pie" >&6; } - if test "$libc_cv_ld_static_pie" != yes; then - as_fn_error $? "linker support for static PIE needed" "$LINENO" 5 - fi -fi - $as_echo "#define PI_STATIC_AND_HIDDEN 1" >>confdefs.h |