diff options
author | Noah Goldstein <goldstein.w.n@gmail.com> | 2022-06-29 16:11:22 -0700 |
---|---|---|
committer | Noah Goldstein <goldstein.w.n@gmail.com> | 2022-07-05 16:42:42 -0700 |
commit | ae308947ff0fa950431d53bcc90c875295d57715 (patch) | |
tree | d14ede08a3dae637cdd57410d42e3dcf00624e2c /sysdeps/x86 | |
parent | 37ecc657b22c3367a56df5ebd53908e34e65fa16 (diff) | |
download | glibc-ae308947ff0fa950431d53bcc90c875295d57715.tar.gz glibc-ae308947ff0fa950431d53bcc90c875295d57715.tar.xz glibc-ae308947ff0fa950431d53bcc90c875295d57715.zip |
x86: Add support for building {w}memcmp{eq} with explicit ISA level
1. Refactor files so that all implementations are in the multiarch directory - Moved the implementation portion of memcmp sse2 from memcmp.S to multiarch/memcmp-sse2.S - The non-multiarch file now only includes one of the implementations in the multiarch directory based on the compiled ISA level (only used for non-multiarch builds. Otherwise we go through the ifunc selector). 2. Add ISA level build guards to different implementations. - I.e memcmp-avx2-movsb.S which is ISA level 3 will only build if compiled ISA level <= 3. Otherwise there is no reason to include it as we will always use one of the ISA level 4 implementations (memcmp-evex-movbe.S). 3. Add new multiarch/rtld-{w}memcmp{eq}.S that just include the non-multiarch {w}memcmp{eq}.S which will in turn select the best implementation based on the compiled ISA level. 4. Refactor the ifunc selector and ifunc implementation list to use the ISA level aware wrapper macros that allow functions below the compiled ISA level (with a guranteed replacement) to be skipped. Tested with and without multiarch on x86_64 for ISA levels: {generic, x86-64-v2, x86-64-v3, x86-64-v4} And m32 with and without multiarch.
Diffstat (limited to 'sysdeps/x86')
-rw-r--r-- | sysdeps/x86/cpu-tunables.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sysdeps/x86/cpu-tunables.c b/sysdeps/x86/cpu-tunables.c index 58f7a7f250..94f4fbf243 100644 --- a/sysdeps/x86/cpu-tunables.c +++ b/sysdeps/x86/cpu-tunables.c @@ -30,7 +30,8 @@ since IFUNC must be set up by init_cpu_features. */ # if defined USE_MULTIARCH && !defined SHARED # ifdef __x86_64__ -# define DEFAULT_MEMCMP __memcmp_sse2 +/* DEFAULT_MEMCMP by sysdeps/x86_64/memcmp-isa-default-impl.h. */ +# include <sysdeps/x86_64/memcmp-isa-default-impl.h> # else # define DEFAULT_MEMCMP __memcmp_ia32 # endif |