diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2020-12-25 07:30:46 -0800 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2021-01-21 05:58:17 -0800 |
commit | ff6d62e9edb5dce537a6dd4a237d6053f331f09c (patch) | |
tree | 0ab59c339851a55cc20ef5c06edaac0119f2b0e2 /sysdeps/x86/get-cpuid-feature-leaf.c | |
parent | d7ee6bd8c217a4deb756739039fa9c165d26ec43 (diff) | |
download | glibc-ff6d62e9edb5dce537a6dd4a237d6053f331f09c.tar.gz glibc-ff6d62e9edb5dce537a6dd4a237d6053f331f09c.tar.xz glibc-ff6d62e9edb5dce537a6dd4a237d6053f331f09c.zip |
<sys/platform/x86.h>: Remove the C preprocessor magic
In <sys/platform/x86.h>, define CPU features as enum instead of using the C preprocessor magic to make it easier to wrap this functionality in other languages. Move the C preprocessor magic to internal header for better GCC codegen when more than one features are checked in a single expression as in x86-64 dl-hwcaps-subdirs.c. 1. Rename COMMON_CPUID_INDEX_XXX to CPUID_INDEX_XXX. 2. Move CPUID_INDEX_MAX to sysdeps/x86/include/cpu-features.h. 3. Remove struct cpu_features and __x86_get_cpu_features from <sys/platform/x86.h>. 4. Add __x86_get_cpuid_feature_leaf to <sys/platform/x86.h> and put it in libc. 5. Make __get_cpu_features() private to glibc. 6. Replace __x86_get_cpu_features(N) with __get_cpu_features(). 7. Add _dl_x86_get_cpu_features to GLIBC_PRIVATE. 8. Use a single enum index for each CPU feature detection. 9. Pass the CPUID feature leaf to __x86_get_cpuid_feature_leaf. 10. Return zero struct cpuid_feature for the older glibc binary with a smaller CPUID_INDEX_MAX [BZ #27104]. 11. Inside glibc, use the C preprocessor magic so that cpu_features data can be loaded just once leading to more compact code for glibc. 256 bits are used for each CPUID leaf. Some leaves only contain a few features. We can add exceptions to such leaves. But it will increase code sizes and it is harder to provide backward/forward compatibilities when new features are added to such leaves in the future. When new leaves are added, _rtld_global_ro offsets will change which leads to race condition during in-place updates. We may avoid in-place updates by 1. Rename the old glibc. 2. Install the new glibc. 3. Remove the old glibc. NB: A function, __x86_get_cpuid_feature_leaf , is used to avoid the copy relocation issue with IFUNC resolver as shown in IFUNC resolver tests.
Diffstat (limited to 'sysdeps/x86/get-cpuid-feature-leaf.c')
-rw-r--r-- | sysdeps/x86/get-cpuid-feature-leaf.c | 30 |
1 files changed, 30 insertions, 0 deletions
diff --git a/sysdeps/x86/get-cpuid-feature-leaf.c b/sysdeps/x86/get-cpuid-feature-leaf.c new file mode 100644 index 0000000000..097e47c7b3 --- /dev/null +++ b/sysdeps/x86/get-cpuid-feature-leaf.c @@ -0,0 +1,30 @@ +/* Get CPUID feature leaf. + Copyright (C) 2021 Free Software Foundation, Inc. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + <https://www.gnu.org/licenses/>. */ + + +#include <ldsodefs.h> + +const struct cpuid_feature * +__x86_get_cpuid_feature_leaf (unsigned int leaf) +{ + static const struct cpuid_feature feature = {}; + if (leaf < CPUID_INDEX_MAX) + return ((const struct cpuid_feature *) + &GLRO(dl_x86_cpu_features).features[leaf]); + else + return &feature; +} |