summary refs log tree commit diff
path: root/sysdeps/unix/sysv/linux/ttyname.h
diff options
context:
space:
mode:
authorChristian Brauner <christian.brauner@canonical.com>2017-01-27 15:59:59 +0100
committerDmitry V. Levin <ldv@altlinux.org>2017-03-19 17:36:13 +0000
commit15e9a4f378c8607c2ae1aa465436af4321db0e23 (patch)
tree021ac3c62fe588a8745fcdf09d29392a837759e0 /sysdeps/unix/sysv/linux/ttyname.h
parent345118d7f5bc42c8d4c3a8ef70b9b709fa57e93d (diff)
downloadglibc-15e9a4f378c8607c2ae1aa465436af4321db0e23.tar.gz
glibc-15e9a4f378c8607c2ae1aa465436af4321db0e23.tar.xz
glibc-15e9a4f378c8607c2ae1aa465436af4321db0e23.zip
linux ttyname and ttyname_r: do not return wrong results
If a link (say /proc/self/fd/0) pointing to a device, say /dev/pts/2, in a
parent mount namespace is passed to ttyname, and a /dev/pts/2 exists (in a
different devpts) in the current namespace, then it returns /dev/pts/2.
But /dev/pts/2 is NOT the current tty, it is a different file and device.

Detect this case and return ENODEV.  Userspace can choose to take this as a hint
that the fd points to a tty device but to act on the fd rather than the link.

Signed-off-by: Serge Hallyn <serge@hallyn.com>
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Diffstat (limited to 'sysdeps/unix/sysv/linux/ttyname.h')
-rw-r--r--sysdeps/unix/sysv/linux/ttyname.h34
1 files changed, 34 insertions, 0 deletions
diff --git a/sysdeps/unix/sysv/linux/ttyname.h b/sysdeps/unix/sysv/linux/ttyname.h
new file mode 100644
index 0000000000..2e415e4e9c
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/ttyname.h
@@ -0,0 +1,34 @@
+/* Copyright (C) 2016-2017 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public License as
+   published by the Free Software Foundation; either version 2.1 of the
+   License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; see the file COPYING.LIB.  If
+   not, see <http://www.gnu.org/licenses/>.  */
+
+#include <unistd.h>
+#include <sys/sysmacros.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+/* Return true if this is a UNIX98 pty device, as defined in
+   linux/Documentation/devices.txt.  */
+static inline int
+is_pty (struct stat64 *sb)
+{
+#ifdef _STATBUF_ST_RDEV
+  int m = major (sb->st_rdev);
+  return (136 <= m && m <= 143);
+#else
+  return false;
+#endif
+}