diff options
author | Stefan Liebler <stli@linux.vnet.ibm.com> | 2016-10-07 09:56:47 +0200 |
---|---|---|
committer | Stefan Liebler <stli@linux.vnet.ibm.com> | 2016-10-07 10:12:46 +0200 |
commit | a4d7fe35cd8f860b1cdf3521834a666447aba4c8 (patch) | |
tree | b3c58d48430f3608affc72f70ad8dbcc09278250 /sysdeps/unix/sysv/linux/powerpc/gettimeofday.c | |
parent | e23faea6aec97b75f7a7567350538c1c0dfc1cee (diff) | |
download | glibc-a4d7fe35cd8f860b1cdf3521834a666447aba4c8.tar.gz glibc-a4d7fe35cd8f860b1cdf3521834a666447aba4c8.tar.xz glibc-a4d7fe35cd8f860b1cdf3521834a666447aba4c8.zip |
ppc: Use libc_ifunc macro for time, gettimeofday.
This patch uses the libc_ifunc_hidden macro to create already existing ifunc functions time and gettimeofday on power. This way, the libc_hidden_def macro can be used instead of inline assemblies. On ppc32, the __GI_* symbols do not target the ifunc symbol and thus the redirection construct has to be applied here. ChangeLog: * sysdeps/unix/sysv/linux/powerpc/gettimeofday.c (__gettimeofday): Use libc_ifunc_hidden and libc_hidden_def macro. Redirect ifunced function in header for using it as type for ifunc function because __GI_* symbols for ppc32 do not target the ifunc symbols. * sysdeps/unix/sysv/linux/powerpc/time.c (time): Likewise.
Diffstat (limited to 'sysdeps/unix/sysv/linux/powerpc/gettimeofday.c')
-rw-r--r-- | sysdeps/unix/sysv/linux/powerpc/gettimeofday.c | 60 |
1 files changed, 31 insertions, 29 deletions
diff --git a/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c b/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c index 25a4e7caff..16c00d7aee 100644 --- a/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c +++ b/sysdeps/unix/sysv/linux/powerpc/gettimeofday.c @@ -15,6 +15,11 @@ License along with the GNU C Library; if not, see <http://www.gnu.org/licenses/>. */ +#if defined SHARED && !defined __powerpc64__ +# define __gettimeofday __redirect___gettimeofday +#else +# define __redirect___gettimeofday __gettimeofday +#endif #include <sys/time.h> @@ -24,30 +29,14 @@ # include <libc-vdso.h> # include <dl-machine.h> -void *gettimeofday_ifunc (void) __asm__ ("__gettimeofday"); - -static int -__gettimeofday_syscall (struct timeval *tv, struct timezone *tz) -{ - return INLINE_SYSCALL (gettimeofday, 2, tv, tz); -} +# ifndef __powerpc64__ +# undef __gettimeofday -void * -gettimeofday_ifunc (void) +int +__gettimeofday_vsyscall (struct timeval *tv, struct timezone *tz) { - PREPARE_VERSION (linux2615, "LINUX_2.6.15", 123718565); - - /* If the vDSO is not available we fall back syscall. */ - void *vdso_gettimeofday = _dl_vdso_vsym ("__kernel_gettimeofday", &linux2615); - return (vdso_gettimeofday ? VDSO_IFUNC_RET (vdso_gettimeofday) - : (void*)__gettimeofday_syscall); + return INLINE_VSYSCALL (gettimeofday, 2, tv, tz); } -asm (".type __gettimeofday, %gnu_indirect_function"); - -/* This is doing "libc_hidden_def (__gettimeofday)" but the compiler won't - let us do it in C because it doesn't know we're defining __gettimeofday - here in this file. */ -asm (".globl __GI___gettimeofday"); /* __GI___gettimeofday is defined as hidden and for ppc32 it enables the compiler make a local call (symbol@local) for internal GLIBC usage. It @@ -55,16 +44,29 @@ asm (".globl __GI___gettimeofday"); For ppc64 a call to a function in another translation unit might use a different toc pointer thus disallowing direct branchess and making internal ifuncs calls safe. */ -#ifdef __powerpc64__ -asm ("__GI___gettimeofday = __gettimeofday"); -#else -int -__gettimeofday_vsyscall (struct timeval *tv, struct timezone *tz) +# undef libc_hidden_def +# define libc_hidden_def(name) \ + __hidden_ver1 (__gettimeofday_vsyscall, __GI___gettimeofday, \ + __gettimeofday_vsyscall); + +# endif /* !__powerpc64__ */ + +static int +__gettimeofday_syscall (struct timeval *tv, struct timezone *tz) { - return INLINE_VSYSCALL (gettimeofday, 2, tv, tz); + return INLINE_SYSCALL (gettimeofday, 2, tv, tz); } -asm ("__GI___gettimeofday = __gettimeofday_vsyscall"); -#endif + +# define INIT_ARCH() \ + PREPARE_VERSION (linux2615, "LINUX_2.6.15", 123718565); \ + void *vdso_gettimeofday = _dl_vdso_vsym ("__kernel_gettimeofday", &linux2615); + +/* If the vDSO is not available we fall back syscall. */ +libc_ifunc_hidden (__redirect___gettimeofday, __gettimeofday, + vdso_gettimeofday + ? VDSO_IFUNC_RET (vdso_gettimeofday) + : (void *) __gettimeofday_syscall); +libc_hidden_def (__gettimeofday) #else |