diff options
author | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2024-08-13 21:08:49 -0400 |
---|---|---|
committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2024-08-28 15:58:45 -0400 |
commit | a500b48bd2a6401de442c00f433079d24331dbb6 (patch) | |
tree | b2db22818bc60aaee4a128046b7b5ed8d6014c73 /sysdeps/unix/sysv/linux/kernel-posix-timers.h | |
parent | 70939528c67507f12d6d41423b7fac25153a6dce (diff) | |
download | glibc-a500b48bd2a6401de442c00f433079d24331dbb6.tar.gz glibc-a500b48bd2a6401de442c00f433079d24331dbb6.tar.xz glibc-a500b48bd2a6401de442c00f433079d24331dbb6.zip |
ungetc: Fix backup buffer leak on program exit [BZ #27821]
If a file descriptor is left unclosed and is cleaned up by _IO_cleanup on exit, its backup buffer remains unfreed, registering as a leak in valgrind. This is not strictly an issue since (1) the program should ideally be closing the stream once it's not in use and (2) the program is about to exit anyway, so keeping the backup buffer around a wee bit longer isn't a real problem. Free it anyway to keep valgrind happy when the streams in question are the standard ones, i.e. stdout, stdin or stderr. Also, the _IO_have_backup macro checks for _IO_save_base, which is a roundabout way to check for a backup buffer instead of directly looking for _IO_backup_base. The roundabout check breaks when the main get area has not been used and user pushes a char into the backup buffer with ungetc. Fix this to use the _IO_backup_base directly. Signed-off-by: Siddhesh Poyarekar <siddhesh@sourceware.org> Reviewed-by: Carlos O'Donell <carlos@redhat.com> (cherry picked from commit 3e1d8d1d1dca24ae90df2ea826a8916896fc7e77)
Diffstat (limited to 'sysdeps/unix/sysv/linux/kernel-posix-timers.h')
0 files changed, 0 insertions, 0 deletions