about summary refs log tree commit diff
path: root/sysdeps/unix/sysv/linux/getdents64.c
diff options
context:
space:
mode:
authorFlorian Weimer <fweimer@redhat.com>2019-06-27 15:08:40 +0200
committerFlorian Weimer <fweimer@redhat.com>2019-06-27 15:08:40 +0200
commita620bd7935c4b2dc94e472e62bd9a5c9434ea7b7 (patch)
tree0741388f6c9acdf7621676f6bf4829f0bb7ac44f /sysdeps/unix/sysv/linux/getdents64.c
parentd039da1c00e01f8d3c3d74f439a971eb73e3045e (diff)
downloadglibc-a620bd7935c4b2dc94e472e62bd9a5c9434ea7b7.tar.gz
glibc-a620bd7935c4b2dc94e472e62bd9a5c9434ea7b7.tar.xz
glibc-a620bd7935c4b2dc94e472e62bd9a5c9434ea7b7.zip
Linux: Adjust gedents64 buffer size to int range [BZ #24740]
The kernel interface uses type unsigned int, but there is an
internal conversion to int, so INT_MAX is the correct limit.
Part of the buffer will always be unused, but this is not a
problem.  Such huge buffers do not occur in practice anyway.

Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/unix/sysv/linux/getdents64.c')
-rw-r--r--sysdeps/unix/sysv/linux/getdents64.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/sysdeps/unix/sysv/linux/getdents64.c b/sysdeps/unix/sysv/linux/getdents64.c
index a6dd22106d..5e3ef9994e 100644
--- a/sysdeps/unix/sysv/linux/getdents64.c
+++ b/sysdeps/unix/sysv/linux/getdents64.c
@@ -19,11 +19,16 @@
 #include <string.h>
 #include <dirent.h>
 #include <errno.h>
+#include <limits.h>
 
 /* The kernel struct linux_dirent64 matches the 'struct dirent64' type.  */
 ssize_t
 __getdents64 (int fd, void *buf, size_t nbytes)
 {
+  /* The system call takes an unsigned int argument, and some length
+     checks in the kernel use an int type.  */
+  if (nbytes > INT_MAX)
+    nbytes = INT_MAX;
   return INLINE_SYSCALL_CALL (getdents64, fd, buf, nbytes);
 }
 libc_hidden_def (__getdents64)