diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2019-02-18 22:33:29 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2019-02-18 22:33:29 +0000 |
| commit | 8c9289b64271639661e5dbe3c19c0badc9db9cfa (patch) | |
| tree | f523846a9aba437bc8682289591ee34793183300 /sysdeps/sparc | |
| parent | 308e022fc46a944700ad5a41530f36aaa6cc7dae (diff) | |
| download | glibc-8c9289b64271639661e5dbe3c19c0badc9db9cfa.tar.gz glibc-8c9289b64271639661e5dbe3c19c0badc9db9cfa.tar.xz glibc-8c9289b64271639661e5dbe3c19c0badc9db9cfa.zip | |
Fix SPARC64 handling of R_SPARC_H34 (bug 24231).
Building glibc with -Wextra shows a -Wimplicit-fallthrough warning for SPARC64 that appears to be a real bug in glibc. The dynamic linker handling of R_SPARC_H34 falls through to that of R_SPARC_H44, which in the case of this code is nonsensical (it means the value computed for R_SPARC_H34 gets overwritten by one computed with the different logic for R_SPARC_H44). Thus, this patch adds the missing break there. Note: I do not have a testcase to demonstrate this bug. Tested with build-many-glibcs.py. [BZ #24231] * sysdeps/sparc/sparc64/dl-machine.h (elf_machine_rela): Add break after R_SPARC_H34 case.
Diffstat (limited to 'sysdeps/sparc')
| -rw-r--r-- | sysdeps/sparc/sparc64/dl-machine.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sysdeps/sparc/sparc64/dl-machine.h b/sysdeps/sparc/sparc64/dl-machine.h index 2fb207dc2d..14930890e3 100644 --- a/sysdeps/sparc/sparc64/dl-machine.h +++ b/sysdeps/sparc/sparc64/dl-machine.h @@ -573,6 +573,7 @@ elf_machine_rela (struct link_map *map, const Elf64_Rela *reloc, *(unsigned int *) reloc_addr = ((*(unsigned int *)reloc_addr & 0xffc00000) | ((value >> 12) & 0x3fffff)); + break; /* MEDMID code model relocs */ case R_SPARC_H44: |