diff options
author | Joseph Myers <joseph@codesourcery.com> | 2021-09-22 21:25:31 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2021-09-22 21:25:31 +0000 |
commit | b3f27d8150d4f3c64063a9a257ec1d228de66398 (patch) | |
tree | 23ea73de01b3e4f37fdc9152d6ffa90f4ba917e6 /sysdeps/sparc | |
parent | b413280cfb16834450f66f554bc0d618bb513851 (diff) | |
download | glibc-b3f27d8150d4f3c64063a9a257ec1d228de66398.tar.gz glibc-b3f27d8150d4f3c64063a9a257ec1d228de66398.tar.xz glibc-b3f27d8150d4f3c64063a9a257ec1d228de66398.zip |
Add narrowing fma functions
This patch adds the narrowing fused multiply-add functions from TS 18661-1 / TS 18661-3 / C2X to glibc's libm: ffma, ffmal, dfmal, f32fmaf64, f32fmaf32x, f32xfmaf64 for all configurations; f32fmaf64x, f32fmaf128, f64fmaf64x, f64fmaf128, f32xfmaf64x, f32xfmaf128, f64xfmaf128 for configurations with _Float64x and _Float128; __f32fmaieee128 and __f64fmaieee128 aliases in the powerpc64le case (for calls to ffmal and dfmal when long double is IEEE binary128). Corresponding tgmath.h macro support is also added. The changes are mostly similar to those for the other narrowing functions previously added, especially that for sqrt, so the description of those generally applies to this patch as well. As with sqrt, I reused the same test inputs in auto-libm-test-in as for non-narrowing fma rather than adding extra or separate inputs for narrowing fma. The tests in libm-test-narrow-fma.inc also follow those for non-narrowing fma. The non-narrowing fma has a known bug (bug 6801) that it does not set errno on errors (overflow, underflow, Inf * 0, Inf - Inf). Rather than fixing this or having narrowing fma check for errors when non-narrowing does not (complicating the cases when narrowing fma can otherwise be an alias for a non-narrowing function), this patch does not attempt to check for errors from narrowing fma and set errno; the CHECK_NARROW_FMA macro is still present, but as a placeholder that does nothing, and this missing errno setting is considered to be covered by the existing bug rather than needing a separate open bug. missing-errno annotations are duly added to many of the auto-libm-test-in test inputs for fma. This completes adding all the new functions from TS 18661-1 to glibc, so will be followed by corresponding stdc-predef.h changes to define __STDC_IEC_60559_BFP__ and __STDC_IEC_60559_COMPLEX__, as the support for TS 18661-1 will be at a similar level to that for C standard floating-point facilities up to C11 (pragmas not implemented, but library functions done). (There are still further changes to be done to implement changes to the types of fromfp functions from N2548.) Tested as followed: natively with the full glibc testsuite for x86_64 (GCC 11, 7, 6) and x86 (GCC 11); with build-many-glibcs.py with GCC 11, 7 and 6; cross testing of math/ tests for powerpc64le, powerpc32 hard float, mips64 (all three ABIs, both hard and soft float). The different GCC versions are to cover the different cases in tgmath.h and tgmath.h tests properly (GCC 6 has _Float* only as typedefs in glibc headers, GCC 7 has proper _Float* support, GCC 8 adds __builtin_tgmath).
Diffstat (limited to 'sysdeps/sparc')
-rw-r--r-- | sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fma.c | 6 | ||||
-rw-r--r-- | sysdeps/sparc/sparc64/fpu/multiarch/s_fma.c | 6 |
2 files changed, 12 insertions, 0 deletions
diff --git a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fma.c b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fma.c index 95f2cea66c..e09eb1a679 100644 --- a/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fma.c +++ b/sysdeps/sparc/sparc32/sparcv9/fpu/multiarch/s_fma.c @@ -1,11 +1,17 @@ #define NO_MATH_REDIRECT #include <sparc-ifunc.h> +#define dfmal __hide_dfmal +#define f32xfmaf64 __hide_f32xfmaf64 #include <math.h> +#undef dfmal +#undef f32xfmaf64 #include <math_ldbl_opt.h> #include <libm-alias-double.h> +#include <math-narrow-alias.h> extern double __fma_vis3 (double, double, double); extern double __fma_generic (double, double, double); sparc_libm_ifunc(__fma, hwcap & HWCAP_SPARC_FMAF ? __fma_vis3 : __fma_generic); libm_alias_double (__fma, fma) +libm_alias_double_narrow (__fma, fma) diff --git a/sysdeps/sparc/sparc64/fpu/multiarch/s_fma.c b/sysdeps/sparc/sparc64/fpu/multiarch/s_fma.c index 44066eed46..abaa6acbe1 100644 --- a/sysdeps/sparc/sparc64/fpu/multiarch/s_fma.c +++ b/sysdeps/sparc/sparc64/fpu/multiarch/s_fma.c @@ -1,7 +1,12 @@ #define NO_MATH_REDIRECT #include <sparc-ifunc.h> +#define dfmal __hide_dfmal +#define f32xfmaf64 __hide_f32xfmaf64 #include <math.h> +#undef dfmal +#undef f32xfmaf64 #include <libm-alias-double.h> +#include <math-narrow-alias.h> extern __typeof (fma) __fma_vis3 attribute_hidden; extern __typeof (fma) __fma_generic attribute_hidden; @@ -11,3 +16,4 @@ sparc_libm_ifunc (__fma, ? __fma_vis3 : __fma_generic); libm_alias_double (__fma, fma) +libm_alias_double_narrow (__fma, fma) |