diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-11-23 21:23:12 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-11-23 21:23:12 +0000 |
| commit | c2a82dace432ef59542bcde8ead2a7050fba51c6 (patch) | |
| tree | 2f5aabd10a97313a22310b562863861f569b04e0 /sysdeps/sh/sh4 | |
| parent | f7f7931e581271c678e0d38818c2022c2da81f8b (diff) | |
| download | glibc-c2a82dace432ef59542bcde8ead2a7050fba51c6.tar.gz glibc-c2a82dace432ef59542bcde8ead2a7050fba51c6.tar.xz glibc-c2a82dace432ef59542bcde8ead2a7050fba51c6.zip | |
Fix SH4 FP_ILOGB0 (bug 20859).
ISO C requires that the value of FP_ILOGB0 must be INT_MIN or -INT_MAX. In sysdeps/sh/sh4/bits/mathdef.h, it's 0x80000001; that is, a positive unsigned value that would be -INT_MAX if converted to int, which is not valid (there's no actual constraint on the type, but whatever the type the integer value must be one of the two permitted, and types other than int don't really make sense). This patch makes the ABI-compatible change to (-0x7fffffff). (The testcase handles positive and negative sign separately to avoid any issues with implicit conversions that could result in e.g. INT_MIN converted to uintmax_t wrongly passing.) Tested (compilation only) with build-many-glibcs.py. [BZ #20859] * sysdeps/sh/sh4/bits/mathdef.h (FP_ILOGB0): Define to (-0x7fffffff) instead of 0x80000001. * math/test-fp-ilogb-constants.c: New file. * math/Makefile (tests): Add test-fp-ilogb-constants.
Diffstat (limited to 'sysdeps/sh/sh4')
| -rw-r--r-- | sysdeps/sh/sh4/bits/mathdef.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sysdeps/sh/sh4/bits/mathdef.h b/sysdeps/sh/sh4/bits/mathdef.h index 90dbebb3fa..21ce094533 100644 --- a/sysdeps/sh/sh4/bits/mathdef.h +++ b/sysdeps/sh/sh4/bits/mathdef.h @@ -34,7 +34,7 @@ typedef float float_t; typedef double double_t; /* The values returned by `ilogb' for 0 and NaN respectively. */ -# define FP_ILOGB0 0x80000001 +# define FP_ILOGB0 (-0x7fffffff) # define FP_ILOGBNAN 0x7fffffff #endif /* ISO C99 */ |