diff options
| author | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
| commit | 098a657fe449a217cf65c5270d5fbc8d40b5b4e6 (patch) | |
| tree | 3721fb17b7746c4dfbe411439f84699f7e6c17a3 /sysdeps/powerpc/tst-tlsifunc.c | |
| parent | e465d97653311c3687aee49de782177353acfe86 (diff) | |
| download | glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.gz glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.xz glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.zip | |
elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC
PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage variables and hidden visibility variables in a shared object (ld.so) need dynamic relocations (usually R_*_RELATIVE). PI (position independent) in the macro name is a misnomer: a code sequence using GOT is typically position-independent as well, but using dynamic relocations does not meet the requirement. Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new ports will define PI_STATIC_AND_HIDDEN. Current ports defining PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure default. No functional change. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/powerpc/tst-tlsifunc.c')
| -rw-r--r-- | sysdeps/powerpc/tst-tlsifunc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sysdeps/powerpc/tst-tlsifunc.c b/sysdeps/powerpc/tst-tlsifunc.c index 6b256c6229..8e559b575d 100644 --- a/sysdeps/powerpc/tst-tlsifunc.c +++ b/sysdeps/powerpc/tst-tlsifunc.c @@ -102,7 +102,7 @@ do_test (void) if (&bar == bar_ptr) printf ("PASS: bar address read from IFUNC resolver is correct.\n"); #if !defined TST_TLSIFUNC_STATIC || !defined PIC \ - || !defined PI_STATIC_AND_HIDDEN + || defined HIDDEN_VAR_NEEDS_DYNAMIC_RELOC else { printf ("FAIL: bar address read from IFUNC resolver is incorrect.\n"); |