diff options
author | Paul A. Clarke <pc@us.ibm.com> | 2021-09-25 09:57:15 -0500 |
---|---|---|
committer | Paul A. Clarke <pc@us.ibm.com> | 2021-09-29 14:42:20 -0500 |
commit | ee874f44fd55988808a4a162ef21bfa2cc8dc6f7 (patch) | |
tree | dc6207510bd32e066d56c3dc8cb7221a57dab3ff /sysdeps/powerpc/tst-set_ppr.c | |
parent | 9bd9978639c2f75dbea5c25226264b1ac11fdf05 (diff) | |
download | glibc-ee874f44fd55988808a4a162ef21bfa2cc8dc6f7.tar.gz glibc-ee874f44fd55988808a4a162ef21bfa2cc8dc6f7.tar.xz glibc-ee874f44fd55988808a4a162ef21bfa2cc8dc6f7.zip |
powerpc: Fix unrecognized instruction errors with recent binutils
Recent versions of binutils (with commit b25f942e18d6ecd7ec3e2d2e9930eb4f996c258a) stopped preserving "sticky" options across a base `.machine` directive, nullifying the use of passing "-many" through GCC to the assembler. As a result, some instructions which were recognized even under older, more stringent `.machine` directives become unrecognized instructions in that context. In `sysdeps/powerpc/tst-set_ppr.c`, the use of the `mfppr32` extended mnemonic became unrecognized, as the default compilation with GCC for 32bit powerpc adds a `.machine ppc` in the resulting assembly, so the command line option `-Wa,-many` is essentially ignored, and the ISA 2.06 instructions and mnemonics, like `mfppr32`, are unrecognized. The compilation of `sysdeps/powerpc/tst-set_ppr.c` fails with: Error: unrecognized opcode: `mfppr32' Add appropriate `.machine` directives in the assembly to bracket the `mfppr32` instruction. Part of a 2019 fix (commit 9250e6610fdb0f3a6f238d2813e319a41fb7a810) to the above test's Makefile to add `-many` to the compilation when GCC itself stopped passing `-many` to the assember no longer has any effect, so remove that. Reported-by: Joseph Myers <joseph@codesourcery.com>
Diffstat (limited to 'sysdeps/powerpc/tst-set_ppr.c')
-rw-r--r-- | sysdeps/powerpc/tst-set_ppr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/sysdeps/powerpc/tst-set_ppr.c b/sysdeps/powerpc/tst-set_ppr.c index 7684f5d6ea..e80da15320 100644 --- a/sysdeps/powerpc/tst-set_ppr.c +++ b/sysdeps/powerpc/tst-set_ppr.c @@ -44,7 +44,8 @@ get_thread_priority (void) { /* Read the PPR. */ ppr_t ppr; - asm volatile (MFPPR" %0" : "=r"(ppr)); + asm volatile (".machine push; .machine power7; "MFPPR" %0; .machine pop" + : "=r"(ppr)); /* Return the thread priority value. */ return EXTRACT_THREAD_PRIORITY (ppr); } |