about summary refs log tree commit diff
path: root/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
diff options
context:
space:
mode:
authorRaoni Fassina Firmino <raoni@linux.ibm.com>2021-05-03 16:59:35 -0300
committerTulio Magno Quites Machado Filho <tuliom@linux.ibm.com>2021-05-07 15:52:23 -0300
commit17a73a6d8b4c46f3e87fc53c7c25fa7cec01d707 (patch)
tree6f8afcb3bf82fe13ff6f3aad2d3d56e4f32f8650 /sysdeps/powerpc/powerpc64/multiarch/bcopy.c
parent310be3cc09d5b1471174bc12f1860169e686bd65 (diff)
downloadglibc-17a73a6d8b4c46f3e87fc53c7c25fa7cec01d707.tar.gz
glibc-17a73a6d8b4c46f3e87fc53c7c25fa7cec01d707.tar.xz
glibc-17a73a6d8b4c46f3e87fc53c7c25fa7cec01d707.zip
powerpc64le: Fix ifunc selection for memset, memmove, bzero and bcopy
The hwcap2 check for the aforementioned functions should check for
both PPC_FEATURE2_ARCH_3_1 and PPC_FEATURE2_HAS_ISEL but was
mistakenly checking for any one of them, enabling isa 3.1 version of
the functions in incompatible processors, like POWER8.

Reviewed-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
Diffstat (limited to 'sysdeps/powerpc/powerpc64/multiarch/bcopy.c')
-rw-r--r--sysdeps/powerpc/powerpc64/multiarch/bcopy.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/sysdeps/powerpc/powerpc64/multiarch/bcopy.c b/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
index 2840b17fdf..02eb1e6a9f 100644
--- a/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
+++ b/sysdeps/powerpc/powerpc64/multiarch/bcopy.c
@@ -28,10 +28,10 @@ extern __typeof (bcopy) __bcopy_power10 attribute_hidden;
 
 libc_ifunc (bcopy,
 #ifdef __LITTLE_ENDIAN__
-	     hwcap2 & (PPC_FEATURE2_ARCH_3_1 |
-		       PPC_FEATURE2_HAS_ISEL)
-	     && (hwcap & PPC_FEATURE_HAS_VSX)
-	     ? __bcopy_power10 :
+	    (hwcap2 & PPC_FEATURE2_ARCH_3_1
+	     && hwcap2 & PPC_FEATURE2_HAS_ISEL
+	     && hwcap & PPC_FEATURE_HAS_VSX)
+	    ? __bcopy_power10 :
 #endif
             (hwcap & PPC_FEATURE_HAS_VSX)
             ? __bcopy_power7