about summary refs log tree commit diff
path: root/sysdeps/nios2
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2018-06-01 17:25:12 +0000
committerJoseph Myers <joseph@codesourcery.com>2018-06-01 17:25:12 +0000
commit0d2163ebf2fbedda09fdebe33243441d89f68b05 (patch)
tree2ed865f0b161db0899aedf8af2d89fac3d191d3b /sysdeps/nios2
parent104502102c6fa322515ba0bb3c95c05c3185da7a (diff)
downloadglibc-0d2163ebf2fbedda09fdebe33243441d89f68b05.tar.gz
glibc-0d2163ebf2fbedda09fdebe33243441d89f68b05.tar.xz
glibc-0d2163ebf2fbedda09fdebe33243441d89f68b05.zip
Make powerpc-nofpu __sqrtsf2, __sqrtdf2 compat symbols (bug 18473).
powerpc-nofpu libc exports __sqrtsf2 and __sqrtdf2 symbols.  The
export of these soft-fp symbols is a mistake; they aren't part of the
libgcc interface and GCC will never generate code that calls them.
This patch makes them into compat symbols (no code built for static
libc), moving their sources from the generic soft-fp sources to
sysdeps/powerpc/nofpu (the underlying soft-fp FP_SQRT functionality
remains of use to implement actual sqrt public interfaces, such as
sqrtl / sqrtf128 for which it is used on various platforms, but
__sqrt[sdt]f2 are not such interfaces).

Tested with build-many-glibcs.py for relevant platforms.

	[BZ #18473]
	* soft-fp/sqrttf2.c: Remove file.
	* soft-fp/sqrtdf2.c: Move to ....
	* sysdeps/powerpc/nofpu/sqrtdf2.c: ... here.  Include
	<shlib-compat.h>.
	(__sqrtdf2): Make conditional on
	[SHLIB_COMPAT (libc, GLIBC_2_3_2, GLIBC_2_28)].  Define as compat
	symbol.
	* soft-fp/sqrtsf2.c: Move to ....
	* sysdeps/powerpc/nofpu/sqrtsf2.c: ... here.  Include
	<shlib-compat.h>.
	(__sqrtsf2): Make conditional on
	[SHLIB_COMPAT (libc, GLIBC_2_3_2, GLIBC_2_28)].  Define as compat
	symbol.
	* soft-fp/Makefile (gcc-single-routines): Remove sqrtsf2.
	(gcc-double-routines): Remove sqrtdf2.
	(gcc-quad-routines): Remove sqrttf2.
	* sysdeps/nios2/Makefile [$(subdir) = soft-fp] (sysdep_routines):
	Do not filter out sqrtsf2 and sqrtdf2.
	* sysdeps/powerpc/nofpu/Makefile [$(subdir) = soft-fp]
	(sysdep_routines): Add sqrtsf2 and sqrtdf2.
Diffstat (limited to 'sysdeps/nios2')
-rw-r--r--sysdeps/nios2/Makefile3
1 files changed, 1 insertions, 2 deletions
diff --git a/sysdeps/nios2/Makefile b/sysdeps/nios2/Makefile
index 16aec3e95c..25fc2abfee 100644
--- a/sysdeps/nios2/Makefile
+++ b/sysdeps/nios2/Makefile
@@ -22,8 +22,7 @@ pic-ccflag = -fpic
 long-double-fcts = no
 
 ifeq ($(subdir),soft-fp)
-sysdep_routines += $(filter-out sqrtsf2,$(gcc-single-routines)) \
-  $(filter-out sqrtdf2,$(gcc-double-routines))
+sysdep_routines += $(gcc-single-routines) $(gcc-double-routines)
 endif
 
 ifeq ($(subdir),csu)