diff options
| author | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
|---|---|---|
| committer | Fangrui Song <maskray@google.com> | 2022-04-26 09:26:22 -0700 |
| commit | 098a657fe449a217cf65c5270d5fbc8d40b5b4e6 (patch) | |
| tree | 3721fb17b7746c4dfbe411439f84699f7e6c17a3 /sysdeps/nios2 | |
| parent | e465d97653311c3687aee49de782177353acfe86 (diff) | |
| download | glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.gz glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.tar.xz glibc-098a657fe449a217cf65c5270d5fbc8d40b5b4e6.zip | |
elf: Replace PI_STATIC_AND_HIDDEN with opposite HIDDEN_VAR_NEEDS_DYNAMIC_RELOC
PI_STATIC_AND_HIDDEN indicates whether accesses to internal linkage variables and hidden visibility variables in a shared object (ld.so) need dynamic relocations (usually R_*_RELATIVE). PI (position independent) in the macro name is a misnomer: a code sequence using GOT is typically position-independent as well, but using dynamic relocations does not meet the requirement. Not defining PI_STATIC_AND_HIDDEN is legacy and we expect that all new ports will define PI_STATIC_AND_HIDDEN. Current ports defining PI_STATIC_AND_HIDDEN are more than the opposite. Change the configure default. No functional change. Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'sysdeps/nios2')
| -rw-r--r-- | sysdeps/nios2/configure | 3 | ||||
| -rw-r--r-- | sysdeps/nios2/configure.ac | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/sysdeps/nios2/configure b/sysdeps/nios2/configure index 14c8a3a014..b3cd28349e 100644 --- a/sysdeps/nios2/configure +++ b/sysdeps/nios2/configure @@ -160,3 +160,6 @@ $as_echo "$libc_cv_nios2_be" >&6; } if test $libc_cv_nios2_be = yes; then as_fn_error $? "Big endian not supported for Nios II" "$LINENO" 5 fi + +$as_echo "#define HIDDEN_VAR_NEEDS_DYNAMIC_RELOC 1" >>confdefs.h + diff --git a/sysdeps/nios2/configure.ac b/sysdeps/nios2/configure.ac index f05f43802b..f738e9a7ed 100644 --- a/sysdeps/nios2/configure.ac +++ b/sysdeps/nios2/configure.ac @@ -11,3 +11,5 @@ AC_CACHE_CHECK([for big endian], if test $libc_cv_nios2_be = yes; then AC_MSG_ERROR([Big endian not supported for Nios II]) fi + +AC_DEFINE(HIDDEN_VAR_NEEDS_DYNAMIC_RELOC) |