diff options
author | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2020-06-28 00:15:56 +0000 |
---|---|---|
committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2020-06-28 00:38:46 +0000 |
commit | 67a78072e2891b8b16a7bfb20675844a5854cff1 (patch) | |
tree | 9eba275153b88aaca083b65c6c2d746f37f0f2e1 /sysdeps/mach | |
parent | 6414eef6e013f46ee94d5f961af15659e1933182 (diff) | |
download | glibc-67a78072e2891b8b16a7bfb20675844a5854cff1.tar.gz glibc-67a78072e2891b8b16a7bfb20675844a5854cff1.tar.xz glibc-67a78072e2891b8b16a7bfb20675844a5854cff1.zip |
hurd: clean fd and port on thread cancel
HURD_*PORT_USE link fd and port with a stack-stored structure, so on thread cancel we need to cleanup this. * hurd/fd-cleanup.c: New file. * hurd/port-cleanup.c (_hurd_port_use_cleanup): New function. * hurd/Makefile (routines): Add fd-cleanup. * sysdeps/hurd/include/hurd.h (__USEPORT_CANCEL): New macro. * sysdeps/hurd/include/hurd/fd.h (_hurd_fd_port_use_data): New structure. (_hurd_fd_port_use_cleanup): New prototype. (HURD_DPORT_USE_CANCEL, HURD_FD_PORT_USE_CANCEL): New macros. * sysdeps/hurd/include/hurd/port.h (_hurd_port_use_data): New structure. (_hurd_port_use_cleanup): New prototype. (HURD_PORT_USE_CANCEL): New macro. * hurd/hurd/fd.h (HURD_FD_PORT_USE): Also refer to HURD_FD_PORT_USE_CANCEL. * hurd/hurd.h (__USEPORT): Also refer to __USEPORT_CANCEL. * hurd/hurd/port.h (HURD_PORT_USE): Also refer to HURD_PORT_USE_CANCEL. * hurd/fd-read.c (_hurd_fd_read): Call HURD_FD_PORT_USE_CANCEL instead of HURD_FD_PORT_USE. * hurd/fd-write.c (_hurd_fd_write): Likewise. * sysdeps/mach/hurd/send.c (__send): Call HURD_DPORT_USE_CANCEL instead of HURD_DPORT_USE. * sysdeps/mach/hurd/sendmsg.c (__libc_sendmsg): Likewise. * sysdeps/mach/hurd/sendto.c (__sendto): Likewise. * sysdeps/mach/hurd/recv.c (__recv): Likewise. * sysdeps/mach/hurd/recvfrom.c (__recvfrom): Likewise. * sysdeps/mach/hurd/recvmsg.c (__libc_recvmsg): Call __USEPORT_CANCEL instead of __USEPORT, and HURD_DPORT_USE_CANCEL instead of HURD_DPORT_USE.
Diffstat (limited to 'sysdeps/mach')
-rw-r--r-- | sysdeps/mach/hurd/recv.c | 12 | ||||
-rw-r--r-- | sysdeps/mach/hurd/recvfrom.c | 12 | ||||
-rw-r--r-- | sysdeps/mach/hurd/recvmsg.c | 12 | ||||
-rw-r--r-- | sysdeps/mach/hurd/send.c | 8 | ||||
-rw-r--r-- | sysdeps/mach/hurd/sendmsg.c | 2 | ||||
-rw-r--r-- | sysdeps/mach/hurd/sendto.c | 2 |
6 files changed, 24 insertions, 24 deletions
diff --git a/sysdeps/mach/hurd/recv.c b/sysdeps/mach/hurd/recv.c index b9ed067265..4fa2f79dcd 100644 --- a/sysdeps/mach/hurd/recv.c +++ b/sysdeps/mach/hurd/recv.c @@ -40,12 +40,12 @@ __recv (int fd, void *buf, size_t n, int flags) int cancel_oldtype; cancel_oldtype = LIBC_CANCEL_ASYNC(); - err = HURD_DPORT_USE (fd, __socket_recv (port, &addrport, - flags, &bufp, &nread, - &ports, &nports, - &cdata, &clen, - &flags, - n)); + err = HURD_DPORT_USE_CANCEL (fd, __socket_recv (port, &addrport, + flags, &bufp, &nread, + &ports, &nports, + &cdata, &clen, + &flags, + n)); LIBC_CANCEL_RESET (cancel_oldtype); if (err == MIG_BAD_ID || err == EOPNOTSUPP) diff --git a/sysdeps/mach/hurd/recvfrom.c b/sysdeps/mach/hurd/recvfrom.c index ed3d970722..2cd7092088 100644 --- a/sysdeps/mach/hurd/recvfrom.c +++ b/sysdeps/mach/hurd/recvfrom.c @@ -43,12 +43,12 @@ __recvfrom (int fd, void *buf, size_t n, int flags, __SOCKADDR_ARG addrarg, int cancel_oldtype; cancel_oldtype = LIBC_CANCEL_ASYNC(); - err = HURD_DPORT_USE (fd, __socket_recv (port, &addrport, - flags, &bufp, &nread, - &ports, &nports, - &cdata, &clen, - &flags, - n)); + err = HURD_DPORT_USE_CANCEL (fd, __socket_recv (port, &addrport, + flags, &bufp, &nread, + &ports, &nports, + &cdata, &clen, + &flags, + n)); LIBC_CANCEL_RESET (cancel_oldtype); if (err) diff --git a/sysdeps/mach/hurd/recvmsg.c b/sysdeps/mach/hurd/recvmsg.c index 75c5f37f0e..5ac130fed1 100644 --- a/sysdeps/mach/hurd/recvmsg.c +++ b/sysdeps/mach/hurd/recvmsg.c @@ -58,7 +58,7 @@ __libc_recvmsg (int fd, struct msghdr *message, int flags) while (err == EINTR); if (!err) do - err = __USEPORT (AUTH, __auth_user_authenticate (port, + err = __USEPORT_CANCEL (AUTH, __auth_user_authenticate (port, ref, MACH_MSG_TYPE_MAKE_SEND, result)); while (err == EINTR); @@ -86,11 +86,11 @@ __libc_recvmsg (int fd, struct msghdr *message, int flags) buf = data; cancel_oldtype = LIBC_CANCEL_ASYNC(); - err = HURD_DPORT_USE (fd, __socket_recv (port, &aport, - flags, &data, &len, - &ports, &nports, - &cdata, &clen, - &message->msg_flags, amount)); + err = HURD_DPORT_USE_CANCEL (fd, __socket_recv (port, &aport, + flags, &data, &len, + &ports, &nports, + &cdata, &clen, + &message->msg_flags, amount)); LIBC_CANCEL_RESET (cancel_oldtype); if (err) return __hurd_sockfail (fd, flags, err); diff --git a/sysdeps/mach/hurd/send.c b/sysdeps/mach/hurd/send.c index 78edbc2ff3..5be6c3a773 100644 --- a/sysdeps/mach/hurd/send.c +++ b/sysdeps/mach/hurd/send.c @@ -31,10 +31,10 @@ __send (int fd, const void *buf, size_t n, int flags) int cancel_oldtype; cancel_oldtype = LIBC_CANCEL_ASYNC(); - err = HURD_DPORT_USE (fd, __socket_send (port, MACH_PORT_NULL, - flags, buf, n, - NULL, MACH_MSG_TYPE_COPY_SEND, 0, - NULL, 0, &wrote)); + err = HURD_DPORT_USE_CANCEL (fd, __socket_send (port, MACH_PORT_NULL, + flags, buf, n, + NULL, MACH_MSG_TYPE_COPY_SEND, 0, + NULL, 0, &wrote)); LIBC_CANCEL_RESET (cancel_oldtype); if (err == MIG_BAD_ID || err == EOPNOTSUPP) diff --git a/sysdeps/mach/hurd/sendmsg.c b/sysdeps/mach/hurd/sendmsg.c index 37ab7f3ce0..d8764c1248 100644 --- a/sysdeps/mach/hurd/sendmsg.c +++ b/sysdeps/mach/hurd/sendmsg.c @@ -174,7 +174,7 @@ __libc_sendmsg (int fd, const struct msghdr *message, int flags) err = EIEIO; } - err = HURD_DPORT_USE (fd, + err = HURD_DPORT_USE_CANCEL (fd, ({ if (err) err = __socket_create_address (port, diff --git a/sysdeps/mach/hurd/sendto.c b/sysdeps/mach/hurd/sendto.c index a5faf8ea2e..aab3d3dcae 100644 --- a/sysdeps/mach/hurd/sendto.c +++ b/sysdeps/mach/hurd/sendto.c @@ -73,7 +73,7 @@ __sendto (int fd, return err_port; } - err = HURD_DPORT_USE (fd, + err = HURD_DPORT_USE_CANCEL (fd, ({ if (addr != NULL) err = create_address_port (port, addr, addr_len, |