diff options
| author | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-07-22 18:38:10 +0530 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-07-22 18:38:10 +0530 |
| commit | 0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd (patch) | |
| tree | baf150b3e1b728c6c13b95116241a61bff5f21ab /sysdeps/mach/hurd | |
| parent | b5bd5bfe88f496463ec9fab680a8edf64d7c2a42 (diff) | |
| download | glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.tar.gz glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.tar.xz glibc-0552fd2c7d4e8a570cb4fe4dfe65e96f6d24b0cd.zip | |
Move malloc_{g,s}et_state to libc_malloc_debug
These deprecated functions are only safe to call from __malloc_initialize_hook and as a result, are not useful in the general case. Move the implementations to libc_malloc_debug so that existing binaries that need it will now have to preload the debug DSO to work correctly. This also allows simplification of the core malloc implementation by dropping all the undumping support code that was added to make malloc_set_state work. One known breakage is that of ancient emacs binaries that depend on this. They will now crash when running with this libc. With LD_BIND_NOW=1, it will terminate immediately because of not being able to find malloc_set_state but with lazy binding it will crash in unpredictable ways. It will need a preloaded libc_malloc_debug.so so that its initialization hook is executed to allow its malloc implementation to work properly. Reviewed-by: Carlos O'Donell <carlos@redhat.com> Tested-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'sysdeps/mach/hurd')
| -rw-r--r-- | sysdeps/mach/hurd/i386/libc.abilist | 2 | ||||
| -rw-r--r-- | sysdeps/mach/hurd/i386/libc_malloc_debug.abilist | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sysdeps/mach/hurd/i386/libc.abilist b/sysdeps/mach/hurd/i386/libc.abilist index b337d0d45b..c5da10a0cd 100644 --- a/sysdeps/mach/hurd/i386/libc.abilist +++ b/sysdeps/mach/hurd/i386/libc.abilist @@ -1267,8 +1267,6 @@ GLIBC_2.2.6 madvise F GLIBC_2.2.6 makecontext F GLIBC_2.2.6 mallinfo F GLIBC_2.2.6 malloc F -GLIBC_2.2.6 malloc_get_state F -GLIBC_2.2.6 malloc_set_state F GLIBC_2.2.6 malloc_stats F GLIBC_2.2.6 malloc_trim F GLIBC_2.2.6 malloc_usable_size F diff --git a/sysdeps/mach/hurd/i386/libc_malloc_debug.abilist b/sysdeps/mach/hurd/i386/libc_malloc_debug.abilist index c1ff86dfbd..e1d9b10b22 100644 --- a/sysdeps/mach/hurd/i386/libc_malloc_debug.abilist +++ b/sysdeps/mach/hurd/i386/libc_malloc_debug.abilist @@ -8,6 +8,8 @@ GLIBC_2.2.6 calloc F GLIBC_2.2.6 free F GLIBC_2.2.6 mallinfo F GLIBC_2.2.6 malloc F +GLIBC_2.2.6 malloc_get_state F +GLIBC_2.2.6 malloc_set_state F GLIBC_2.2.6 malloc_stats F GLIBC_2.2.6 malloc_trim F GLIBC_2.2.6 malloc_usable_size F |