diff options
| author | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2021-03-23 22:38:54 +0000 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2021-03-23 22:40:10 +0000 |
| commit | c3b287be74e12bdb15ed36e98d24fd42f8ee9122 (patch) | |
| tree | 82a9f85685a35bf5b12e480ee6ed1abc24103dc8 /sysdeps/mach/hurd/setuid.c | |
| parent | a4ea18ec6cc3f1370efab09bc18c1badbf74aa13 (diff) | |
| download | glibc-c3b287be74e12bdb15ed36e98d24fd42f8ee9122.tar.gz glibc-c3b287be74e12bdb15ed36e98d24fd42f8ee9122.tar.xz glibc-c3b287be74e12bdb15ed36e98d24fd42f8ee9122.zip | |
hurd: handle EINTR during critical sections
During critical sections, signal handling is deferred and thus RPCs return EINTR, even if SA_RESTART is set. We thus have to restart the whole critical section in that case. This also adds HURD_CRITICAL_UNLOCK in the cases where one wants to break the section in the middle.
Diffstat (limited to 'sysdeps/mach/hurd/setuid.c')
| -rw-r--r-- | sysdeps/mach/hurd/setuid.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/sysdeps/mach/hurd/setuid.c b/sysdeps/mach/hurd/setuid.c index ede3f014c4..4818357c62 100644 --- a/sysdeps/mach/hurd/setuid.c +++ b/sysdeps/mach/hurd/setuid.c @@ -32,6 +32,7 @@ __setuid (uid_t uid) auth_t newauth; error_t err; +retry: HURD_CRITICAL_BEGIN; __mutex_lock (&_hurd_id.lock); err = _hurd_check_ids (); @@ -86,6 +87,9 @@ __setuid (uid_t uid) } __mutex_unlock (&_hurd_id.lock); HURD_CRITICAL_END; + if (err == EINTR) + /* Got a signal while inside an RPC of the critical section, retry again */ + goto retry; if (err) return __hurd_fail (err); |