about summary refs log tree commit diff
path: root/sysdeps/mach/getsysstats.c
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2024-02-05 16:10:24 +0000
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2024-02-05 15:43:27 -0300
commiteee7525d35ec16bbe81435e41079ab72519d825c (patch)
treea7fe74a800296c094fe5a19a1ee636b46c615600 /sysdeps/mach/getsysstats.c
parent8b849f70b397bae04ddad20ace07561103a8260a (diff)
downloadglibc-eee7525d35ec16bbe81435e41079ab72519d825c.tar.gz
glibc-eee7525d35ec16bbe81435e41079ab72519d825c.tar.xz
glibc-eee7525d35ec16bbe81435e41079ab72519d825c.zip
arm: Remove wrong ldr from _dl_start_user (BZ 31339)
The commit 49d877a80b29d3002887b084eec6676d9f5fec18 (arm: Remove
_dl_skip_args usage) removed the _SKIP_ARGS literal, which was
previously loader to r4 on loader _start.  However, the cleanup did not
remove the following 'ldr r4, [sl, r4]' on _dl_start_user, used to check
to skip the arguments after ld self-relocations.

In my testing, the kernel initially set r4 to 0, which makes the
ldr instruction just read the _GLOBAL_OFFSET_TABLE_.  However, since r4
is a callee-saved register; a different runtime might not zero
initialize it and thus trigger an invalid memory access.

Checked on arm-linux-gnu.

Reported-by: Adrian Ratiu <adrian.ratiu@collabora.com>
Reviewed-by: Szabolcs Nagy <szabolcs.nagy@arm.com>
(cherry picked from commit 1e25112dc0cb2515d27d8d178b1ecce778a9d37a)
Diffstat (limited to 'sysdeps/mach/getsysstats.c')
0 files changed, 0 insertions, 0 deletions