diff options
author | Adhemerval Zanella <azanella@linux.vnet.ibm.com> | 2012-04-11 16:30:13 -0300 |
---|---|---|
committer | Andreas Jaeger <aj@suse.de> | 2012-04-17 22:12:53 +0200 |
commit | 76da7265320010c7a273ed99f53938c0f32d5fad (patch) | |
tree | f094871a5f38652d2d320a11423fee602a8746e6 /sysdeps/ieee754 | |
parent | 0396e69dbefb3630651d93e0a7526c4326a071bb (diff) | |
download | glibc-76da7265320010c7a273ed99f53938c0f32d5fad.tar.gz glibc-76da7265320010c7a273ed99f53938c0f32d5fad.tar.xz glibc-76da7265320010c7a273ed99f53938c0f32d5fad.zip |
Fix ilogb exception and errno (bug 6794)
[BZ #6794] Following Joseph comments about bug 6794, here is a proposed fix. It turned out to be a large fix mainly because I had to move some file along to follow libm files/names conventions. Basically I have added wrappers (w_ilogb.c, w_ilogbf.c, w_ilogbl.c) that now calls the symbol '__ieee754_ilogb'. The wrappers checks for '__ieee754_ilogb' output and set the errno and raise exceptions as expected. The '__ieee754_ilogb' is implemented in sysdeps. I have moved the 's_ilogb[f|l]' files to e_ilogb[f|l] and renamed the '__ilogb[f|l]' to '__ieee754_ilogb[f|l]'. I also found out a bug in i386 and x86-64 assembly coded ilogb implementation where it raises a FE_DIVBYZERO when argument is '0.0'. I corrected this issue as well. Finally I added the errno and FE_INVALID tests for 0.0, NaN and +-InF argument. Tested on i386, x86-64, ppc32 and ppc64.
Diffstat (limited to 'sysdeps/ieee754')
-rw-r--r-- | sysdeps/ieee754/dbl-64/e_ilogb.c (renamed from sysdeps/ieee754/dbl-64/s_ilogb.c) | 8 | ||||
-rw-r--r-- | sysdeps/ieee754/flt-32/e_ilogbf.c (renamed from sysdeps/ieee754/flt-32/s_ilogbf.c) | 4 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-128ibm/e_ilogbl.c (renamed from sysdeps/ieee754/ldbl-128ibm/s_ilogbl.c) | 3 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-opt/w_ilogb.c (renamed from sysdeps/ieee754/ldbl-opt/s_ilogb.c) | 2 | ||||
-rw-r--r-- | sysdeps/ieee754/ldbl-opt/w_ilogbl.c | 5 |
5 files changed, 11 insertions, 11 deletions
diff --git a/sysdeps/ieee754/dbl-64/s_ilogb.c b/sysdeps/ieee754/dbl-64/e_ilogb.c index 05c66d70fe..7772880a1f 100644 --- a/sysdeps/ieee754/dbl-64/s_ilogb.c +++ b/sysdeps/ieee754/dbl-64/e_ilogb.c @@ -25,7 +25,7 @@ static char rcsid[] = "$NetBSD: s_ilogb.c,v 1.9 1995/05/10 20:47:28 jtc Exp $"; #include <math.h> #include <math_private.h> -int __ilogb(double x) +int __ieee754_ilogb(double x) { int32_t hx,lx,ix; @@ -52,8 +52,4 @@ int __ilogb(double x) } return FP_ILOGBNAN; } -weak_alias (__ilogb, ilogb) -#ifdef NO_LONG_DOUBLE -strong_alias (__ilogb, __ilogbl) -weak_alias (__ilogb, ilogbl) -#endif +strong_alias (__ieee754_ilogb, __ilogb_finite) diff --git a/sysdeps/ieee754/flt-32/s_ilogbf.c b/sysdeps/ieee754/flt-32/e_ilogbf.c index 21f9cd9704..c7441a8561 100644 --- a/sysdeps/ieee754/flt-32/s_ilogbf.c +++ b/sysdeps/ieee754/flt-32/e_ilogbf.c @@ -21,7 +21,7 @@ static char rcsid[] = "$NetBSD: s_ilogbf.c,v 1.4 1995/05/10 20:47:31 jtc Exp $"; #include <math.h> #include <math_private.h> -int __ilogbf(float x) +int __ieee754_ilogbf(float x) { int32_t hx,ix; @@ -42,4 +42,4 @@ int __ilogbf(float x) } return FP_ILOGBNAN; } -weak_alias (__ilogbf, ilogbf) +strong_alias (__ieee754_ilogbf, __ilogbf_finite) diff --git a/sysdeps/ieee754/ldbl-128ibm/s_ilogbl.c b/sysdeps/ieee754/ldbl-128ibm/e_ilogbl.c index a6f0e1e678..55f87ed422 100644 --- a/sysdeps/ieee754/ldbl-128ibm/s_ilogbl.c +++ b/sysdeps/ieee754/ldbl-128ibm/e_ilogbl.c @@ -29,7 +29,7 @@ static char rcsid[] = "$NetBSD: $"; #include <math_private.h> #include <math_ldbl_opt.h> -int __ilogbl(long double x) +int __ieee754_ilogbl(long double x) { int64_t hx,lx; int ix; @@ -55,4 +55,3 @@ int __ilogbl(long double x) } return FP_ILOGBNAN; } -long_double_symbol (libm, __ilogbl, ilogbl); diff --git a/sysdeps/ieee754/ldbl-opt/s_ilogb.c b/sysdeps/ieee754/ldbl-opt/w_ilogb.c index 3a6ccbd09d..f518087a5f 100644 --- a/sysdeps/ieee754/ldbl-opt/s_ilogb.c +++ b/sysdeps/ieee754/ldbl-opt/w_ilogb.c @@ -1,5 +1,5 @@ #include <math_ldbl_opt.h> -#include <sysdeps/ieee754/dbl-64/s_ilogb.c> +#include <math/w_ilogb.c> #if LONG_DOUBLE_COMPAT(libm, GLIBC_2_0) compat_symbol (libm, __ilogb, ilogbl, GLIBC_2_0); #endif diff --git a/sysdeps/ieee754/ldbl-opt/w_ilogbl.c b/sysdeps/ieee754/ldbl-opt/w_ilogbl.c new file mode 100644 index 0000000000..36f83f6ade --- /dev/null +++ b/sysdeps/ieee754/ldbl-opt/w_ilogbl.c @@ -0,0 +1,5 @@ +#include <math_ldbl_opt.h> +#undef weak_alias +#define weak_alias(n,a) +#include <math/w_ilogbl.c> +long_double_symbol (libm, __ilogbl, ilogbl); |