diff options
author | Joseph Myers <joseph@codesourcery.com> | 2014-06-27 14:52:13 +0000 |
---|---|---|
committer | Joseph Myers <joseph@codesourcery.com> | 2014-06-27 14:52:13 +0000 |
commit | be25493251c014a696b62834b0e63b155d8fe353 (patch) | |
tree | 2a7ed0745694dfd02fb848ddc702a262acd31fe1 /sysdeps/ieee754/flt-32/e_jnf.c | |
parent | b351d85aa284f81271bc93e11301e1c2466b7c82 (diff) | |
download | glibc-be25493251c014a696b62834b0e63b155d8fe353.tar.gz glibc-be25493251c014a696b62834b0e63b155d8fe353.tar.xz glibc-be25493251c014a696b62834b0e63b155d8fe353.zip |
Fix yn overflow handling in non-default rounding modes (bug 16561, bug 16562).
This patch fixes bugs 16561 and 16562, bad results of yn in overflow cases in non-default rounding modes, both because an intermediate overflow in the recurrence does not get detected if the result is not an infinity and because an overflowing result may occur in the wrong sign. The fix is to set FE_TONEAREST mode internally for the parts of the function where such overflows can occur (which includes the call to y1 - where yn is used to compute a Bessel function of order -1, negating the result of y1 isn't correct for overflowing results in directed rounding modes) and then compute an overflowing value in the original rounding mode if the to-nearest result was an infinity. Tested x86_64 and x86 and ulps updated accordingly. Also tested for mips64 and powerpc32 to test the ldbl-128 and ldbl-128ibm changes. (The tests for these bugs were added in my previous y1 patch, so the only thing this patch has to do with the testsuite is enable yn testing in all rounding modes.) [BZ #16561] [BZ #16562] * sysdeps/ieee754/dbl-64/e_jn.c: Include <float.h>. (__ieee754_yn): Set FE_TONEAREST mode internally and then recompute overflowing results in original rounding mode. * sysdeps/ieee754/flt-32/e_jnf.c: Include <float.h>. (__ieee754_ynf): Set FE_TONEAREST mode internally and then recompute overflowing results in original rounding mode. * sysdeps/ieee754/ldbl-128/e_jnl.c: Include <float.h>. (__ieee754_ynl): Set FE_TONEAREST mode internally and then recompute overflowing results in original rounding mode. * sysdeps/ieee754/ldbl-128ibm/e_jnl.c: Include <float.h>. (__ieee754_ynl): Set FE_TONEAREST mode internally and then recompute overflowing results in original rounding mode. * sysdeps/ieee754/ldbl-96/e_jnl.c: Include <float.h>. (__ieee754_ynl): Set FE_TONEAREST mode internally and then recompute overflowing results in original rounding mode. * sysdeps/i386/fpu/fenv_private.h [!__SSE2_MATH__] (libc_feholdsetround_ctx): New macro. * math/libm-test.inc (yn_test): Use ALL_RM_TEST. * sysdeps/i386/fpu/libm-test-ulps: Update. * sysdeps/x86_64/fpu/libm-test-ulps : Likewise.
Diffstat (limited to 'sysdeps/ieee754/flt-32/e_jnf.c')
-rw-r--r-- | sysdeps/ieee754/flt-32/e_jnf.c | 16 |
1 files changed, 14 insertions, 2 deletions
diff --git a/sysdeps/ieee754/flt-32/e_jnf.c b/sysdeps/ieee754/flt-32/e_jnf.c index 5984d94a3c..86085cc635 100644 --- a/sysdeps/ieee754/flt-32/e_jnf.c +++ b/sysdeps/ieee754/flt-32/e_jnf.c @@ -14,6 +14,7 @@ */ #include <errno.h> +#include <float.h> #include <math.h> #include <math_private.h> @@ -169,6 +170,8 @@ strong_alias (__ieee754_jnf, __jnf_finite) float __ieee754_ynf(int n, float x) { + float ret; + { int32_t i,hx,ix; u_int32_t ib; int32_t sign; @@ -187,7 +190,11 @@ __ieee754_ynf(int n, float x) sign = 1 - ((n&1)<<1); } if(n==0) return(__ieee754_y0f(x)); - if(n==1) return(sign*__ieee754_y1f(x)); + SET_RESTORE_ROUNDF (FE_TONEAREST); + if(n==1) { + ret = sign*__ieee754_y1f(x); + goto out; + } if(__builtin_expect(ix==0x7f800000, 0)) return zero; a = __ieee754_y0f(x); @@ -203,6 +210,11 @@ __ieee754_ynf(int n, float x) /* If B is +-Inf, set up errno accordingly. */ if (! __finitef (b)) __set_errno (ERANGE); - if(sign>0) return b; else return -b; + if(sign>0) ret = b; else ret = -b; + } + out: + if (__isinff (ret)) + ret = __copysignf (FLT_MAX, ret) * FLT_MAX; + return ret; } strong_alias (__ieee754_ynf, __ynf_finite) |