diff options
| author | Martin Jansa <martin.jansa@gmail.com> | 2019-01-04 16:17:48 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2019-01-04 16:17:48 +0000 |
| commit | 27c5e756a2a8495d77480a103081a86c1ca9a1e8 (patch) | |
| tree | 031c60ad881ba347d7ec850d85377928bb1f9232 /sysdeps/ieee754/dbl-64 | |
| parent | 8b18d418bd0ef1d2b1093e5b956bf176f41f4828 (diff) | |
| download | glibc-27c5e756a2a8495d77480a103081a86c1ca9a1e8.tar.gz glibc-27c5e756a2a8495d77480a103081a86c1ca9a1e8.tar.xz glibc-27c5e756a2a8495d77480a103081a86c1ca9a1e8.zip | |
sysdeps/ieee754: prevent maybe-uninitialized errors with -O [BZ #19444]
With -O included in CFLAGS it fails to build with:
../sysdeps/ieee754/ldbl-96/e_jnl.c: In function '__ieee754_jnl':
../sysdeps/ieee754/ldbl-96/e_jnl.c:146:20: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
b = invsqrtpi * temp / sqrtl (x);
~~~~~~~~~~^~~~~~
../sysdeps/ieee754/ldbl-96/e_jnl.c: In function '__ieee754_ynl':
../sysdeps/ieee754/ldbl-96/e_jnl.c:375:16: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
b = invsqrtpi * temp / sqrtl (x);
~~~~~~~~~~^~~~~~
../sysdeps/ieee754/dbl-64/e_jn.c: In function '__ieee754_jn':
../sysdeps/ieee754/dbl-64/e_jn.c:113:20: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
b = invsqrtpi * temp / sqrt (x);
~~~~~~~~~~^~~~~~
../sysdeps/ieee754/dbl-64/e_jn.c: In function '__ieee754_yn':
../sysdeps/ieee754/dbl-64/e_jn.c:320:16: error: 'temp' may be used uninitialized in this function [-Werror=maybe-uninitialized]
b = invsqrtpi * temp / sqrt (x);
~~~~~~~~~~^~~~~~
Build tested with Yocto for ARM, AARCH64, X86, X86_64, PPC, MIPS, MIPS64
with -O, -O1, -Os.
For AARCH64 it needs one more fix in locale for -Os:
https://sourceware.org/ml/libc-alpha/2018-09/msg00539.html
[BZ #19444]
* sysdeps/ieee754/dbl-64/e_jn.c (__ieee754_jn): Use
__builtin_unreachable for default case in switch.
(__ieee754_yn): Likewise.
* sysdeps/ieee754/ldbl-96/e_jnl.c (__ieee754_jnl): Likewise.
(__ieee754_ynl): Likewise.
* sysdeps/ieee754/ldbl-128/e_jnl.c (__ieee754_jnl): Likewise.
(__ieee754_ynl): Likewise.
* sysdeps/ieee754/ldbl-128ibm/e_jnl.c (__ieee754_jnl): Likewise.
(__ieee754_ynl): Likewise.
Diffstat (limited to 'sysdeps/ieee754/dbl-64')
| -rw-r--r-- | sysdeps/ieee754/dbl-64/e_jn.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sysdeps/ieee754/dbl-64/e_jn.c b/sysdeps/ieee754/dbl-64/e_jn.c index aff06ead16..90a7e77270 100644 --- a/sysdeps/ieee754/dbl-64/e_jn.c +++ b/sysdeps/ieee754/dbl-64/e_jn.c @@ -109,6 +109,7 @@ __ieee754_jn (int n, double x) case 1: temp = -c + s; break; case 2: temp = -c - s; break; case 3: temp = c - s; break; + default: __builtin_unreachable (); } b = invsqrtpi * temp / sqrt (x); } @@ -316,6 +317,7 @@ __ieee754_yn (int n, double x) case 1: temp = -s - c; break; case 2: temp = -s + c; break; case 3: temp = s + c; break; + default: __builtin_unreachable (); } b = invsqrtpi * temp / sqrt (x); } |