diff options
| author | Adhemerval Zanella Netto <adhemerval.zanella@linaro.org> | 2023-03-20 13:01:18 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2023-04-03 16:45:27 -0300 |
| commit | 16439f419b270184ec501c531bf20d83b6745fb0 (patch) | |
| tree | e4f3223ddea72c871c2177c5257243c4c3df25ec /sysdeps/i386 | |
| parent | cf9cf33199fdd6550920ad43f19ad8b2435fc0c6 (diff) | |
| download | glibc-16439f419b270184ec501c531bf20d83b6745fb0.tar.gz glibc-16439f419b270184ec501c531bf20d83b6745fb0.tar.xz glibc-16439f419b270184ec501c531bf20d83b6745fb0.zip | |
math: Remove the error handling wrapper from fmod and fmodf
The error handling is moved to sysdeps/ieee754 version with no SVID support. The compatibility symbol versions still use the wrapper with SVID error handling around the new code. There is no new symbol version nor compatibility code on !LIBM_SVID_COMPAT targets (e.g. riscv). The ia64 is unchanged, since it still uses the arch specific __libm_error_region on its implementation. For both i686 and m68k, which provive arch specific implementation, wrappers are added so no new symbol are added (which would require to change the implementations). It shows an small improvement, the results for fmod: Architecture | Input | master | patch -----------------|-----------------|----------|-------- x86_64 (Ryzen 9) | subnormals | 12.5049 | 9.40992 x86_64 (Ryzen 9) | normal | 296.939 | 296.738 x86_64 (Ryzen 9) | close-exponents | 16.0244 | 13.119 aarch64 (N1) | subnormal | 6.81778 | 4.33313 aarch64 (N1) | normal | 155.620 | 152.915 aarch64 (N1) | close-exponents | 8.21306 | 5.76138 armhf (N1) | subnormal | 15.1083 | 14.5746 armhf (N1) | normal | 244.833 | 241.738 armhf (N1) | close-exponents | 21.8182 | 22.457 Checked on x86_64-linux-gnu, i686-linux-gnu, and aarch64-linux-gnu. Reviewed-by: Wilco Dijkstra <Wilco.Dijkstra@arm.com>
Diffstat (limited to 'sysdeps/i386')
| -rw-r--r-- | sysdeps/i386/fpu/w_fmod_compat.c | 14 | ||||
| -rw-r--r-- | sysdeps/i386/fpu/w_fmodf_compat.c | 14 |
2 files changed, 28 insertions, 0 deletions
diff --git a/sysdeps/i386/fpu/w_fmod_compat.c b/sysdeps/i386/fpu/w_fmod_compat.c new file mode 100644 index 0000000000..5ac9995ffd --- /dev/null +++ b/sysdeps/i386/fpu/w_fmod_compat.c @@ -0,0 +1,14 @@ +/* i386 provides an optimized __ieee752_fmod. */ +#include <math-svid-compat.h> +#ifdef SHARED +# undef SHLIB_COMPAT +# define SHLIB_COMPAT(a, b, c) 1 +# undef LIBM_SVID_COMPAT +# define LIBM_SVID_COMPAT 1 +# undef compat_symbol +# define compat_symbol(a, b, c, d) +#endif +#include <math/w_fmod_compat.c> +#ifdef SHARED +libm_alias_double (__fmod_compat, fmod) +#endif diff --git a/sysdeps/i386/fpu/w_fmodf_compat.c b/sysdeps/i386/fpu/w_fmodf_compat.c new file mode 100644 index 0000000000..cc417e07d3 --- /dev/null +++ b/sysdeps/i386/fpu/w_fmodf_compat.c @@ -0,0 +1,14 @@ +/* i386 provides an optimized __ieee752_fmodf. */ +#include <math-svid-compat.h> +#ifdef SHARED +# undef SHLIB_COMPAT +# define SHLIB_COMPAT(a, b, c) 1 +# undef LIBM_SVID_COMPAT +# define LIBM_SVID_COMPAT 1 +# undef compat_symbol +# define compat_symbol(a, b, c, d) +#endif +#include <math/w_fmodf_compat.c> +#ifdef SHARED +libm_alias_float (__fmod_compat, fmod) +#endif |