diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2015-09-18 20:34:59 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2015-09-18 20:34:59 +0000 |
| commit | 94ced920a951bcab51f2ef955ccd2cc51668e6f3 (patch) | |
| tree | 703e39203cb6fc889572c9feb9acc7db37b750f8 /sysdeps/i386/fpu/s_scalbn.S | |
| parent | 89faa0340ad399ead8104f8fb6b7fed81f7d939c (diff) | |
| download | glibc-94ced920a951bcab51f2ef955ccd2cc51668e6f3.tar.gz glibc-94ced920a951bcab51f2ef955ccd2cc51668e6f3.tar.xz glibc-94ced920a951bcab51f2ef955ccd2cc51668e6f3.zip | |
Avoid excess range in results from i386 scalb functions (bug 18981).
i386 scalb / scalbn / scalbln (and thus ldexp) functions for float and double can return results with excess range (and consequently excess precision for subnormal results). As the results of these functions are fully determined by reference to IEEE 754 operations, this is unambiguously a bug, apart from the testsuite failures it causes. This patch makes those functions store their results on the stack and load them back to eliminate the excess range. Double rounding is not a problem, as the only cases where it could occur are when the result overflows or underflows for extended precision, and then the double-rounded results are the same as the single-rounded results. The new macros will be used for more functions, more such macros added, and existing code refactored to use such macros, in subsequent patches. Tested for x86. Committed. [BZ #18981] * sysdeps/i386/fpu/i386-math-asm.h: New file. * sysdeps/i386/fpu/e_scalb.S: Include <i386-math-asm.h>. (__ieee754_scalb): Use DBL_NARROW_EVAL. * sysdeps/i386/fpu/e_scalbf.S: Include <i386-math-asm.h>. (__ieee754_scalbf): Use FLT_NARROW_EVAL. * sysdeps/i386/fpu/s_scalbn.S: Include <i386-math-asm.h>. (__scalbn): Use DBL_NARROW_EVAL. * sysdeps/i386/fpu/s_scalbnf.S: Include <i386-math-asm.h>. (__scalbnf): Use FLT_NARROW_EVAL.
Diffstat (limited to 'sysdeps/i386/fpu/s_scalbn.S')
| -rw-r--r-- | sysdeps/i386/fpu/s_scalbn.S | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sysdeps/i386/fpu/s_scalbn.S b/sysdeps/i386/fpu/s_scalbn.S index dab75801c5..4e90903115 100644 --- a/sysdeps/i386/fpu/s_scalbn.S +++ b/sysdeps/i386/fpu/s_scalbn.S @@ -4,6 +4,7 @@ */ #include <machine/asm.h> +#include <i386-math-asm.h> RCSID("$NetBSD: s_scalbn.S,v 1.4 1995/05/09 00:19:06 jtc Exp $") @@ -12,6 +13,7 @@ ENTRY(__scalbn) fldl 4(%esp) fscale fstp %st(1) + DBL_NARROW_EVAL ret END (__scalbn) strong_alias (__scalbn, __scalbln) |