diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2014-05-14 12:38:56 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2014-05-14 12:38:56 +0000 |
| commit | 1a84c3d6d4bc43c92b6531b09d732e2e9c750dea (patch) | |
| tree | f58a4fd81f814868dad8426ca0da232b618e0ac2 /sysdeps/i386/fpu/s_log1pl.S | |
| parent | 01dbacd22a8d5e0053f8d0cf13a80286b6cfe79b (diff) | |
| download | glibc-1a84c3d6d4bc43c92b6531b09d732e2e9c750dea.tar.gz glibc-1a84c3d6d4bc43c92b6531b09d732e2e9c750dea.tar.xz glibc-1a84c3d6d4bc43c92b6531b09d732e2e9c750dea.zip | |
Fix log1pl (LDBL_MAX) in FE_UPWARD mode (bug 16564).
Bug 16564 is spurious overflow of log1pl (LDBL_MAX) in FE_UPWARD mode, resulting from log1pl adding 1 to its argument (for arguments not close to 0), which overflows in that mode. This patch fixes this by avoiding adding 1 to large arguments (precisely what counts as large depends on the floating-point format). Tested x86_64 and x86, and spot-checked log1pl tests on mips64 and powerpc64. [BZ #16564] * sysdeps/i386/fpu/s_log1pl.S (__log1pl): Do not add 1 to positive arguments with exponent 65 or above. * sysdeps/ieee754/ldbl-128/s_log1pl.c (__log1pl): Do not add 1 to arguments 0x1p113L or above. * sysdeps/ieee754/ldbl-128ibm/s_log1pl.c (__log1pl): Do not add 1 to arguments 0x1p107L or above. * sysdeps/x86_64/fpu/s_log1pl.S (__log1pl): Do not add 1 to positive arguments with exponent 65 or above. * math/auto-libm-test-in: Add more tests of log1p. * math/auto-libm-test-out: Regenerated.
Diffstat (limited to 'sysdeps/i386/fpu/s_log1pl.S')
| -rw-r--r-- | sysdeps/i386/fpu/s_log1pl.S | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/sysdeps/i386/fpu/s_log1pl.S b/sysdeps/i386/fpu/s_log1pl.S index 93c07b637c..d2d5d3bc7c 100644 --- a/sysdeps/i386/fpu/s_log1pl.S +++ b/sysdeps/i386/fpu/s_log1pl.S @@ -53,12 +53,17 @@ ENTRY(__log1pl) sahf jnc 2f + movzwl 4+8(%esp), %eax + xorb $0x80, %ah + cmpl $0xc040, %eax + jae 5f + #ifdef PIC faddl one@GOTOFF(%edx) #else faddl one #endif - fyl2x +5: fyl2x ret 2: fyl2xp1 |