about summary refs log tree commit diff
path: root/sysdeps/generic/setenv.c
diff options
context:
space:
mode:
authorUlrich Drepper <drepper@redhat.com>1999-07-07 18:02:39 +0000
committerUlrich Drepper <drepper@redhat.com>1999-07-07 18:02:39 +0000
commit2556bfe6fdb5ccb4864e0249d5fdd475e4100c71 (patch)
treeceb6911987c23a31476484b3c390ce85057c597c /sysdeps/generic/setenv.c
parent9ae6fc542a6267377078f1c64f45bc9bd2a96da5 (diff)
downloadglibc-2556bfe6fdb5ccb4864e0249d5fdd475e4100c71.tar.gz
glibc-2556bfe6fdb5ccb4864e0249d5fdd475e4100c71.tar.xz
glibc-2556bfe6fdb5ccb4864e0249d5fdd475e4100c71.zip
Update.
	* sysdeps/generic/setenv.c: Describe problem.

	* malloc/malloc.c (request2size): Also set errno if failing.
Diffstat (limited to 'sysdeps/generic/setenv.c')
-rw-r--r--sysdeps/generic/setenv.c19
1 files changed, 18 insertions, 1 deletions
diff --git a/sysdeps/generic/setenv.c b/sysdeps/generic/setenv.c
index 21d9b675cb..a5818d03bf 100644
--- a/sysdeps/generic/setenv.c
+++ b/sysdeps/generic/setenv.c
@@ -1,4 +1,4 @@
-/* Copyright (C) 1992, 1995, 1996, 1997, 1998 Free Software Foundation, Inc.
+/* Copyright (C) 1992, 95, 96, 97, 98, 99 Free Software Foundation, Inc.
    This file is part of the GNU C Library.
 
    The GNU C Library is free software; you can redistribute it and/or
@@ -16,6 +16,23 @@
    write to the Free Software Foundation, Inc., 59 Temple Place - Suite 330,
    Boston, MA 02111-1307, USA.  */
 
+/* Issues:
+
+   1. putenv must not use setenv since the string provided by the user
+      must be used, not a copy
+
+   2. a common function should determine the place where to insert the
+      new entry and if necessary take care of extending the array
+
+   3. It must be kept track of whether an entry was inserted via putenv
+      or setenv.  In the former case the entry must not be put into
+      the search tree since removing it could mean it will not be
+      available anymore (e.g., when allocated on the stack)
+
+      To handle this an array parallel to the __environ array must specify
+      whether the entry was added via putenv or not
+*/
+
 #if HAVE_CONFIG_H
 # include <config.h>
 #endif