diff options
author | Zack Weinberg <zackw@panix.com> | 2019-08-16 21:10:11 -0400 |
---|---|---|
committer | Zack Weinberg <zackw@panix.com> | 2019-08-21 08:26:36 -0400 |
commit | 1baae4aa6f3313da77d799f12f963910b05db637 (patch) | |
tree | 8e355e8254a1e5f93b381f552ab5e95a3dd64fcf /string | |
parent | f9fabc1b02d252d5d9b2e0df406bb394b8a7b46a (diff) | |
download | glibc-1baae4aa6f3313da77d799f12f963910b05db637.tar.gz glibc-1baae4aa6f3313da77d799f12f963910b05db637.tar.xz glibc-1baae4aa6f3313da77d799f12f963910b05db637.zip |
Don't use the argument to time.
It doesn't make sense to remove all the internal uses of time. It's still a standard ISO C function, and its callers don't need sub-second resolution and would be unnecessarily complicated if they had to declare a struct timespec instead of just a time_t. However, a handful of places were using the vestigial "result" argument instead of the return value, which is slightly less efficient and also looks strange. Correct this. * misc/syslog.c (__vsyslog_internal) * time/getdate.c (__getdate_r) * time/tst_wcsftime.c (main): Use return value of time, not its argument. * string/strfry.c (strfry) * sysdeps/mach/sleep.c (__sleep): Remove unnecessary casts of NULL in calls to time.
Diffstat (limited to 'string')
-rw-r--r-- | string/strfry.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/string/strfry.c b/string/strfry.c index af6087bee5..71686d45c2 100644 --- a/string/strfry.c +++ b/string/strfry.c @@ -30,7 +30,7 @@ strfry (char *string) { static char state[32]; rdata.state = NULL; - __initstate_r (time ((time_t *) NULL) ^ getpid (), + __initstate_r (time (NULL) ^ getpid (), state, sizeof (state), &rdata); init = 1; } |