about summary refs log tree commit diff
path: root/stdlib/tst-thread-quick_exit.cc
diff options
context:
space:
mode:
authorCarlos O'Donell <carlos@redhat.com>2016-06-06 14:20:58 -0400
committerCarlos O'Donell <carlos@redhat.com>2016-06-06 21:40:25 -0400
commit47dd3543d36465496970406da03db5aecdc377ee (patch)
tree2288d28761125dcb0b27e150f76314d064decc43 /stdlib/tst-thread-quick_exit.cc
parent3f61232ab337b8162ed1a37558b30ce714dba894 (diff)
downloadglibc-47dd3543d36465496970406da03db5aecdc377ee.tar.gz
glibc-47dd3543d36465496970406da03db5aecdc377ee.tar.xz
glibc-47dd3543d36465496970406da03db5aecdc377ee.zip
Bug 20198: quick_exit should not call destructors.
In C++11 18.5.12 says "Objects shall not be destroyed as a
result of calling quick_exit." In C11 quick_exit is silent
about thread object destruction. Therefore to make glibc
C++ compliant we do not call any thread local destructors.
A new regression test verifies the fix.

I will note that C++11 18.5.3 makes it clear that C++
defines additional requirements for _Exit() to prevent it
from executing destructors.

Given that the point of _Exit() is to terminate the process
immediately it makes sense the C and C++ should line up
and avoid calling destructors.

No failures. New regtest passes.
Diffstat (limited to 'stdlib/tst-thread-quick_exit.cc')
-rw-r--r--stdlib/tst-thread-quick_exit.cc50
1 files changed, 50 insertions, 0 deletions
diff --git a/stdlib/tst-thread-quick_exit.cc b/stdlib/tst-thread-quick_exit.cc
new file mode 100644
index 0000000000..307d2a2430
--- /dev/null
+++ b/stdlib/tst-thread-quick_exit.cc
@@ -0,0 +1,50 @@
+/* Bug 20198: Do not call object destructors at exit.
+   Copyright (C) 2016 Free Software Foundation, Inc.
+   This file is part of the GNU C Library.
+
+   The GNU C Library is free software; you can redistribute it and/or
+   modify it under the terms of the GNU Lesser General Public
+   License as published by the Free Software Foundation; either
+   version 2.1 of the License, or (at your option) any later version.
+
+   The GNU C Library is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   Lesser General Public License for more details.
+
+   You should have received a copy of the GNU Lesser General Public
+   License along with the GNU C Library; if not, see
+   <http://www.gnu.org/licenses/>.  */
+#include <cstdlib>
+#include <thread>
+
+struct A
+{
+  ~A() { abort(); }
+};
+
+thread_local A a1;
+thread_local A a2;
+
+/* Call std::quick_exit from a non-main thread.  */
+void non_main_thread (void)
+{
+  (void)a1;
+  /* The C++11 standard in 18.5.12 says:
+     "Objects shall not be destroyed as a result of calling
+      quick_exit."
+     If quick_exit calls the destructors the test aborts.  */
+  std::quick_exit (0);
+}
+
+static int
+do_test()
+{
+  (void)a2;
+  std::thread th (non_main_thread);
+  th.join ();
+  return 0;
+}
+
+#define TEST_FUNCTION do_test ()
+#include "../test-skeleton.c"