summary refs log tree commit diff
path: root/stdlib/exit.c
diff options
context:
space:
mode:
authorCarlos O'Donell <carlos@redhat.com>2016-06-06 14:20:58 -0400
committerCarlos O'Donell <carlos@redhat.com>2016-06-06 21:40:25 -0400
commit47dd3543d36465496970406da03db5aecdc377ee (patch)
tree2288d28761125dcb0b27e150f76314d064decc43 /stdlib/exit.c
parent3f61232ab337b8162ed1a37558b30ce714dba894 (diff)
downloadglibc-47dd3543d36465496970406da03db5aecdc377ee.tar.gz
glibc-47dd3543d36465496970406da03db5aecdc377ee.tar.xz
glibc-47dd3543d36465496970406da03db5aecdc377ee.zip
Bug 20198: quick_exit should not call destructors.
In C++11 18.5.12 says "Objects shall not be destroyed as a
result of calling quick_exit." In C11 quick_exit is silent
about thread object destruction. Therefore to make glibc
C++ compliant we do not call any thread local destructors.
A new regression test verifies the fix.

I will note that C++11 18.5.3 makes it clear that C++
defines additional requirements for _Exit() to prevent it
from executing destructors.

Given that the point of _Exit() is to terminate the process
immediately it makes sense the C and C++ should line up
and avoid calling destructors.

No failures. New regtest passes.
Diffstat (limited to 'stdlib/exit.c')
-rw-r--r--stdlib/exit.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/stdlib/exit.c b/stdlib/exit.c
index 9d3c5f48df..b50b178c24 100644
--- a/stdlib/exit.c
+++ b/stdlib/exit.c
@@ -31,13 +31,14 @@ DEFINE_HOOK (__libc_atexit, (void))
 void
 attribute_hidden
 __run_exit_handlers (int status, struct exit_function_list **listp,
-		     bool run_list_atexit)
+		     bool run_list_atexit, bool run_dtors)
 {
   /* First, call the TLS destructors.  */
 #ifndef SHARED
   if (&__call_tls_dtors != NULL)
 #endif
-    __call_tls_dtors ();
+    if (run_dtors)
+      __call_tls_dtors ();
 
   /* We do it this way to handle recursive calls to exit () made by
      the functions registered with `atexit' and `on_exit'. We call
@@ -101,6 +102,6 @@ __run_exit_handlers (int status, struct exit_function_list **listp,
 void
 exit (int status)
 {
-  __run_exit_handlers (status, &__exit_funcs, true);
+  __run_exit_handlers (status, &__exit_funcs, true, true);
 }
 libc_hidden_def (exit)