diff options
| author | Joseph Myers <joseph@codesourcery.com> | 2016-11-16 22:46:48 +0000 |
|---|---|---|
| committer | Joseph Myers <joseph@codesourcery.com> | 2016-11-16 22:46:48 +0000 |
| commit | 61158ffa9a17476d88aaf4a833d13b12f1c51387 (patch) | |
| tree | 2113e63413caa6d97c0e9bf0b905afbfd4a7eee0 /stdio-common | |
| parent | 7773556dfb2bf62f7b6deda66fa3821a3bcdbf3e (diff) | |
| download | glibc-61158ffa9a17476d88aaf4a833d13b12f1c51387.tar.gz glibc-61158ffa9a17476d88aaf4a833d13b12f1c51387.tar.xz glibc-61158ffa9a17476d88aaf4a833d13b12f1c51387.zip | |
Fix crypt snprintf namespace (bug 20829).
Extending linknamespace tests to cover libcrypt showed that crypt brings in references to snprintf, but is in XPG3 and XPG4 which don't have snprintf. This patch fixes it to use __snprintf instead, exporting __snprintf from libc.so at version GLIBC_PRIVATE and adding libc_hidden_proto / libc_hidden_def accordingly. Tested for x86_64 and x86, in conjunction with the testsuite changes to enable linknamespace testing for libdl and libcrypt. Also tested (compilation only) for powerpc to make sure there were no problem interactions with the optional-long-double handling for snprintf. [BZ #20829] * stdio-common/Versions (__snprintf): Add to version GLIBC_PRIVATE. * include/stdio.h (__snprintf): Use libc_hidden_proto. * stdio-common/snprintf.c (__snprintf): Use libc_hidden_def. * crypt/sha256-crypt.c (__sha256_crypt_r): Use __snprintf instead of snprintf. * crypt/sha512-crypt.c (__sha512_crypt_r): Likewise.
Diffstat (limited to 'stdio-common')
| -rw-r--r-- | stdio-common/Versions | 2 | ||||
| -rw-r--r-- | stdio-common/snprintf.c | 1 |
2 files changed, 3 insertions, 0 deletions
diff --git a/stdio-common/Versions b/stdio-common/Versions index 06b96f678a..5016f69c20 100644 --- a/stdio-common/Versions +++ b/stdio-common/Versions @@ -60,5 +60,7 @@ libc { GLIBC_PRIVATE { # global variables _itoa_lower_digits; + # Used in libcrypt. + __snprintf; } } diff --git a/stdio-common/snprintf.c b/stdio-common/snprintf.c index a3cc518976..ce7ce06077 100644 --- a/stdio-common/snprintf.c +++ b/stdio-common/snprintf.c @@ -35,4 +35,5 @@ __snprintf (char *s, size_t maxlen, const char *format, ...) return done; } +libc_hidden_def (__snprintf) ldbl_weak_alias (__snprintf, snprintf) |