diff options
author | Noah Goldstein <goldstein.w.n@gmail.com> | 2024-08-13 23:29:14 +0800 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2024-08-15 15:42:39 -0700 |
commit | f82e0922de82ccee60c15d5ffd9e7165ced00a83 (patch) | |
tree | ed568e79534354f517d5a82849c1b44aad3c9c2c /stdio-common/sprintf.c | |
parent | 6e642a47fa483f1f571a7ca68d8f6517b259cd21 (diff) | |
download | glibc-f82e0922de82ccee60c15d5ffd9e7165ced00a83.tar.gz glibc-f82e0922de82ccee60c15d5ffd9e7165ced00a83.tar.xz glibc-f82e0922de82ccee60c15d5ffd9e7165ced00a83.zip |
x86: Fix bug in strchrnul-evex512 [BZ #32078]
Issue was we were expecting not matches with CHAR before the start of the string in the page cross case. The check code in the page cross case: ``` and $0xffffffffffffffc0,%rax vmovdqa64 (%rax),%zmm17 vpcmpneqb %zmm17,%zmm16,%k1 vptestmb %zmm17,%zmm17,%k0{%k1} kmovq %k0,%rax inc %rax shr %cl,%rax je L(continue) ``` expects that all characters that neither match null nor CHAR will be 1s in `rax` prior to the `inc`. Then the `inc` will overflow all of the 1s where no relevant match was found. This is incorrect in the page-cross case, as the `vmovdqa64 (%rax),%zmm17` loads from before the start of the input string. If there are matches with CHAR before the start of the string, `rax` won't properly overflow. The fix is quite simple. Just replace: ``` inc %rax shr %cl,%rax ``` With: ``` sar %cl,%rax inc %rax ``` The arithmetic shift will clear any matches prior to the start of the string while maintaining the signbit so the 1s can properly overflow to zero in the case of no matches. Reviewed-by: H.J. Lu <hjl.tools@gmail.com> (cherry picked from commit 7da08862471dfec6fdae731c2a5f351ad485c71f)
Diffstat (limited to 'stdio-common/sprintf.c')
0 files changed, 0 insertions, 0 deletions