about summary refs log tree commit diff
path: root/stdio-common/Makefile
diff options
context:
space:
mode:
authorAdhemerval Zanella <adhemerval.zanella@linaro.org>2016-04-26 17:40:25 -0300
committerAdhemerval Zanella <adhemerval.zanella@linaro.org>2016-04-26 17:40:25 -0300
commitf9123b5003e62b6e54996076e860f23aee9a0593 (patch)
treec32d506730558f13d1c93c3296c698a6a61cd7a0 /stdio-common/Makefile
parent085bbece2c6afc5f13698b52fac0299445c4317f (diff)
downloadglibc-f9123b5003e62b6e54996076e860f23aee9a0593.tar.gz
glibc-f9123b5003e62b6e54996076e860f23aee9a0593.tar.xz
glibc-f9123b5003e62b6e54996076e860f23aee9a0593.zip
libio: Update internal fmemopen position after write (BZ #20005)
Current GLIBC fmemopen fails with a simple testcase:

  char buffer[500] = "x";
  FILE *stream;
  stream = fmemopen(buffer, 500, "r+");
  fwrite("fish",sizeof(char),5,stream);
  printf("pos-1:%ld\n",ftell(stream));
  fflush(stream);
  printf("pos-2:%ld\n",ftell(stream));

It returns:

  pos-1:5
  pos-2:0

Where it should return:

  pos-1:5
  pos-2:5

This is due the internal write function does not correctly update the internal
object position state and then the seek operation returns a wrong value.  This
patch fixes it.

It fixes both BZ #20005 and BZ #19230 (marked as duplicated). A new test is
added to check for such case.

Tested on x86_64 and i686.

	* libio/fmemopen.c (fmemopen_write): Update internal position after
	write.
	* stdio-common/Makefile (tests): Add tst-fmemopen4.c.
	* stdio-common/tst-fmemopen4.c: New file..
Diffstat (limited to 'stdio-common/Makefile')
-rw-r--r--stdio-common/Makefile2
1 files changed, 1 insertions, 1 deletions
diff --git a/stdio-common/Makefile b/stdio-common/Makefile
index 6c597c1926..4c4834bea0 100644
--- a/stdio-common/Makefile
+++ b/stdio-common/Makefile
@@ -58,7 +58,7 @@ tests := tstscanf test_rdwr test-popen tstgetln test-fseek \
 	 scanf16 scanf17 tst-setvbuf1 tst-grouping bug23 bug24 \
 	 bug-vfprintf-nargs tst-long-dbl-fphex tst-fphex-wide tst-sprintf3 \
 	 bug25 tst-printf-round bug23-2 bug23-3 bug23-4 bug26 tst-fmemopen3 \
-	 tst-printf-bz18872 tst-vfprintf-width-prec
+	 tst-printf-bz18872 tst-vfprintf-width-prec tst-fmemopen4
 
 test-srcs = tst-unbputc tst-printf