about summary refs log tree commit diff
path: root/soft-fp/fmadf4.c
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2015-05-22 20:28:50 +0000
committerJoseph Myers <joseph@codesourcery.com>2015-05-22 20:28:50 +0000
commitdc6b5aed1b406a53c4512d355376b4e12c7da971 (patch)
tree5678bbd4e11ba04cf330afc7421db3d95162baae /soft-fp/fmadf4.c
parent0c3717e7827969895f6ffe57c66e1612358ce6b1 (diff)
downloadglibc-dc6b5aed1b406a53c4512d355376b4e12c7da971.tar.gz
glibc-dc6b5aed1b406a53c4512d355376b4e12c7da971.tar.xz
glibc-dc6b5aed1b406a53c4512d355376b4e12c7da971.zip
Fix soft-fp fma for -Wuninitialized.
The soft-fp implementations of fma produce -Wuninitialized warnings
because, in the cases where the result is not a nonzero finite value,
the soft-fp does not set the exponent of the result since the (cooked)
packing will do so, but the compiler does not then see that the
exponent is always set in packing before it's used if it wasn't set
earlier.  This patch uses DIAG_* macros to suppress those warnings.

Tested for mips64.  (In fact this allows the mips64 build to complete
with the -Wno-uninitialized removed from math/Makefile, but more
cleanups are still needed in the ldbl-128ibm code for uninitialized
warnings there.)

	* soft-fp/fmadf4.c: Include <libc-internal.h>.
	(__fma): Ignore uninitialized warnings around packing.
	* soft-fp/fmasf4.c: Include <libc-internal.h>.
	(__fmaf): Ignore uninitialized warnings around packing.
	* soft-fp/fmatf4.c: Include <libc-internal.h>.
	(__fmal): Ignore uninitialized warnings around packing.
Diffstat (limited to 'soft-fp/fmadf4.c')
-rw-r--r--soft-fp/fmadf4.c12
1 files changed, 12 insertions, 0 deletions
diff --git a/soft-fp/fmadf4.c b/soft-fp/fmadf4.c
index 1a720ba020..da6749d0ec 100644
--- a/soft-fp/fmadf4.c
+++ b/soft-fp/fmadf4.c
@@ -25,6 +25,7 @@
    License along with the GNU C Library; if not, see
    <http://www.gnu.org/licenses/>.  */
 
+#include <libc-internal.h>
 #include <math.h>
 #include "soft-fp.h"
 #include "double.h"
@@ -44,7 +45,18 @@ __fma (double a, double b, double c)
   FP_UNPACK_D (B, b);
   FP_UNPACK_D (C, c);
   FP_FMA_D (R, A, B, C);
+  /* R_e is not set in cases where it is not used in packing, but the
+     compiler does not see that it is set in all cases where it is
+     used, resulting in warnings that it may be used
+     uninitialized.  */
+  DIAG_PUSH_NEEDS_COMMENT;
+#if __GNUC_PREREQ (4, 7)
+  DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wmaybe-uninitialized");
+#else
+  DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wuninitialized");
+#endif
   FP_PACK_D (r, R);
+  DIAG_POP_NEEDS_COMMENT;
   FP_HANDLE_EXCEPTIONS;
 
   return r;