diff options
| author | Florian Weimer <fweimer@redhat.com> | 2016-03-29 12:57:56 +0200 |
|---|---|---|
| committer | Tulio Magno Quites Machado Filho <tuliom@linux.vnet.ibm.com> | 2016-04-01 09:33:23 -0300 |
| commit | 883dceebc8f11921a9890211a4e202e5be17562f (patch) | |
| tree | ee331090ddc6ab448f39dd789b69d412da3c71de /resolv/nss_dns/dns-network.c | |
| parent | 5a1a5f0dd2744044801c91bf2588444c29cda533 (diff) | |
| download | glibc-883dceebc8f11921a9890211a4e202e5be17562f.tar.gz glibc-883dceebc8f11921a9890211a4e202e5be17562f.tar.xz glibc-883dceebc8f11921a9890211a4e202e5be17562f.zip | |
CVE-2016-3075: Stack overflow in _nss_dns_getnetbyname_r [BZ #19879]
The defensive copy is not needed because the name may not alias the output buffer. (cherry picked from commit 317b199b4aff8cfa27f2302ab404d2bb5032b9a4)
Diffstat (limited to 'resolv/nss_dns/dns-network.c')
| -rw-r--r-- | resolv/nss_dns/dns-network.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/resolv/nss_dns/dns-network.c b/resolv/nss_dns/dns-network.c index 00f4490c5d..89f8783fbe 100644 --- a/resolv/nss_dns/dns-network.c +++ b/resolv/nss_dns/dns-network.c @@ -118,17 +118,14 @@ _nss_dns_getnetbyname_r (const char *name, struct netent *result, } net_buffer; querybuf *orig_net_buffer; int anslen; - char *qbuf; enum nss_status status; if (__res_maybe_init (&_res, 0) == -1) return NSS_STATUS_UNAVAIL; - qbuf = strdupa (name); - net_buffer.buf = orig_net_buffer = (querybuf *) alloca (1024); - anslen = __libc_res_nsearch (&_res, qbuf, C_IN, T_PTR, net_buffer.buf->buf, + anslen = __libc_res_nsearch (&_res, name, C_IN, T_PTR, net_buffer.buf->buf, 1024, &net_buffer.ptr, NULL, NULL, NULL, NULL); if (anslen < 0) { |