diff options
author | Florian Weimer <fweimer@redhat.com> | 2019-01-21 21:26:03 +0100 |
---|---|---|
committer | Florian Weimer <fweimer@redhat.com> | 2019-01-21 21:26:03 +0100 |
commit | 108bc4049f8ae82710aec26a92ffdb4b439c83fd (patch) | |
tree | 8028ac534476871bac578df4435bf0bf7388f672 /resolv/Makefile | |
parent | 5165de69c0908e28a380cbd4bb054e55ea4abc95 (diff) | |
download | glibc-108bc4049f8ae82710aec26a92ffdb4b439c83fd.tar.gz glibc-108bc4049f8ae82710aec26a92ffdb4b439c83fd.tar.xz glibc-108bc4049f8ae82710aec26a92ffdb4b439c83fd.zip |
CVE-2016-10739: getaddrinfo: Fully parse IPv4 address strings [BZ #20018]
The IPv4 address parser in the getaddrinfo function is changed so that it does not ignore trailing whitespace and all characters after it. For backwards compatibility, the getaddrinfo function still recognizes legacy name syntax, such as 192.000.002.010 interpreted as 192.0.2.8 (octal). This commit does not change the behavior of inet_addr and inet_aton. gethostbyname already had additional sanity checks (but is switched over to the new __inet_aton_exact function for completeness as well). To avoid sending the problematic query names over DNS, commit 6ca53a2453598804a2559a548a08424fca96434a ("resolv: Do not send queries for non-host-names in nss_dns [BZ #24112]") is needed.
Diffstat (limited to 'resolv/Makefile')
-rw-r--r-- | resolv/Makefile | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/resolv/Makefile b/resolv/Makefile index 450e171b01..8f22e6a154 100644 --- a/resolv/Makefile +++ b/resolv/Makefile @@ -34,6 +34,9 @@ routines := herror inet_addr inet_ntop inet_pton nsap_addr res_init \ tests = tst-aton tst-leaks tst-inet_ntop xtests = tst-leaks2 +tests-internal += tst-inet_aton_exact + + generate := mtrace-tst-leaks.out tst-leaks.mtrace tst-leaks2.mtrace extra-libs := libresolv libnss_dns @@ -54,8 +57,10 @@ tests += \ tst-resolv-binary \ tst-resolv-edns \ tst-resolv-network \ + tst-resolv-nondecimal \ tst-resolv-res_init-multi \ tst-resolv-search \ + tst-resolv-trailing \ # These tests need libdl. ifeq (yes,$(build-shared)) @@ -190,9 +195,11 @@ $(objpfx)tst-resolv-res_init-multi: $(objpfx)libresolv.so \ $(shared-thread-library) $(objpfx)tst-resolv-res_init-thread: $(libdl) $(objpfx)libresolv.so \ $(shared-thread-library) +$(objpfx)tst-resolv-nondecimal: $(objpfx)libresolv.so $(shared-thread-library) $(objpfx)tst-resolv-qtypes: $(objpfx)libresolv.so $(shared-thread-library) $(objpfx)tst-resolv-rotate: $(objpfx)libresolv.so $(shared-thread-library) $(objpfx)tst-resolv-search: $(objpfx)libresolv.so $(shared-thread-library) +$(objpfx)tst-resolv-trailing: $(objpfx)libresolv.so $(shared-thread-library) $(objpfx)tst-resolv-threads: \ $(libdl) $(objpfx)libresolv.so $(shared-thread-library) $(objpfx)tst-resolv-canonname: \ |