diff options
author | H.J. Lu <hjl.tools@gmail.com> | 2017-06-23 14:38:46 -0700 |
---|---|---|
committer | H.J. Lu <hjl.tools@gmail.com> | 2017-07-19 03:39:49 -0700 |
commit | 2f919bf21329d130036d92682ec4cef390f09321 (patch) | |
tree | 4d70072e9302561cbae398dd37f1ab22e681d728 /ports/sysdeps/m68k/memchr.S | |
parent | 7cdbe5b6f929b820b9dc92dbfa6ff48b4e6e133d (diff) | |
download | glibc-hjl/pr21666/2.25.tar.gz glibc-hjl/pr21666/2.25.tar.xz glibc-hjl/pr21666/2.25.zip |
Avoid .symver on common symbols [BZ #21666] hjl/pr21666/2.25
The .symver directive on common symbol just creates a new common symbol, not an alias and the newer assembler with the bug fix for https://sourceware.org/bugzilla/show_bug.cgi?id=21661 will issue an error. Before the fix, we got $ readelf -sW libc.so | grep "loc[12s]" 5109: 00000000003a0608 8 OBJECT LOCAL DEFAULT 36 loc1 5188: 00000000003a0610 8 OBJECT LOCAL DEFAULT 36 loc2 5455: 00000000003a0618 8 OBJECT LOCAL DEFAULT 36 locs 6575: 00000000003a05f0 8 OBJECT GLOBAL DEFAULT 36 locs@GLIBC_2.2.5 7156: 00000000003a05f8 8 OBJECT GLOBAL DEFAULT 36 loc1@GLIBC_2.2.5 7312: 00000000003a0600 8 OBJECT GLOBAL DEFAULT 36 loc2@GLIBC_2.2.5 in libc.so. The versioned loc1, loc2 and locs have the wrong addresses. After the fix, we got $ readelf -sW libc.so | grep "loc[12s]" 6570: 000000000039e3b8 8 OBJECT GLOBAL DEFAULT 34 locs@GLIBC_2.2.5 7151: 000000000039e3c8 8 OBJECT GLOBAL DEFAULT 34 loc1@GLIBC_2.2.5 7307: 000000000039e3c0 8 OBJECT GLOBAL DEFAULT 34 loc2@GLIBC_2.2.5 [BZ #21666] * misc/regexp.c (loc1): Add __attribute__ ((nocommon)); (loc2): Likewise. (locs): Likewise. (cherry picked from commit 388b4f1a02f3a801965028bbfcd48d905638b797)
Diffstat (limited to 'ports/sysdeps/m68k/memchr.S')
0 files changed, 0 insertions, 0 deletions