diff options
| author | DJ Delorie <dj@redhat.com> | 2021-02-25 16:08:21 -0500 |
|---|---|---|
| committer | Siddhesh Poyarekar <siddhesh@sourceware.org> | 2021-03-08 15:14:51 +0530 |
| commit | a151f2e05a64727c552a297d129b8ef242ffb3b6 (patch) | |
| tree | 8e328051b1c170c8f0275db8fbd3e7427e90befc /nscd | |
| parent | ee9f98d9cac12e843ca59c6e4d4b225f58a66727 (diff) | |
| download | glibc-a151f2e05a64727c552a297d129b8ef242ffb3b6.tar.gz glibc-a151f2e05a64727c552a297d129b8ef242ffb3b6.tar.xz glibc-a151f2e05a64727c552a297d129b8ef242ffb3b6.zip | |
nscd: Fix double free in netgroupcache [BZ #27462]
In commit 745664bd798ec8fd50438605948eea594179fba1 a use-after-free was fixed, but this led to an occasional double-free. This patch tracks the "live" allocation better. Tested manually by a third party. Related: RHBZ 1927877 Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org> Reviewed-by: Carlos O'Donell <carlos@redhat.com> (cherry picked from commit dca565886b5e8bd7966e15f0ca42ee5cff686673)
Diffstat (limited to 'nscd')
| -rw-r--r-- | nscd/netgroupcache.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c index dba6ceec1b..ad2daddafd 100644 --- a/nscd/netgroupcache.c +++ b/nscd/netgroupcache.c @@ -248,7 +248,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req, : NULL); ndomain = (ndomain ? newbuf + ndomaindiff : NULL); - buffer = newbuf; + *tofreep = buffer = newbuf; } nhost = memcpy (buffer + bufused, @@ -319,7 +319,7 @@ addgetnetgrentX (struct database_dyn *db, int fd, request_header *req, else if (status == NSS_STATUS_TRYAGAIN && e == ERANGE) { buflen *= 2; - buffer = xrealloc (buffer, buflen); + *tofreep = buffer = xrealloc (buffer, buflen); } else if (status == NSS_STATUS_RETURN || status == NSS_STATUS_NOTFOUND |