summary refs log tree commit diff
path: root/nscd
diff options
context:
space:
mode:
authorJoseph Myers <joseph@codesourcery.com>2019-02-04 14:48:43 +0000
committerJoseph Myers <joseph@codesourcery.com>2019-02-04 14:49:37 +0000
commit7a0dcfc6439cd4e19bf393c2e2347e385361a82c (patch)
tree29d2f89f3590efc6800e9d3c8f85a9c93051d2f2 /nscd
parent65f7767a914144ae303f7b9ae81865061793dcb9 (diff)
downloadglibc-7a0dcfc6439cd4e19bf393c2e2347e385361a82c.tar.gz
glibc-7a0dcfc6439cd4e19bf393c2e2347e385361a82c.tar.xz
glibc-7a0dcfc6439cd4e19bf393c2e2347e385361a82c.zip
Remove duplicate initialization of field in nscd.
I'm looking at the warnings from building glibc with -Wextra, to see
if we could use -Wextra by default, possibly with a few of its
warnings disabled, and so benefit from warnings in -Wextra but not in
-Wall.  (The vast bulk of the extra warnings so produced are from
-Wunused-parameter -Wsign-compare -Wmissing-field-initializers
-Wtype-limits, so I expect those would be disabled at least at first.)

Various miscellaneous warnings show up with -Wextra that it clearly
seems to make sense to fix independent of whether we add -Wextra to
the normal options for building glibc.  This patch fixes one:
"initialized field overwritten [-Woverride-init]" in nscd.

Tested for x86_64.

	* nscd/connections.c (reqinfo): Initialize SHUTDOWN element only
	once.
Diffstat (limited to 'nscd')
-rw-r--r--nscd/connections.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/nscd/connections.c b/nscd/connections.c
index 61cf27e24c..a9bc00de90 100644
--- a/nscd/connections.c
+++ b/nscd/connections.c
@@ -227,7 +227,6 @@ static struct
   [GETHOSTBYADDRv6] = { true, &dbs[hstdb] },
   [SHUTDOWN] = { false, NULL },
   [GETSTAT] = { false, NULL },
-  [SHUTDOWN] = { false, NULL },
   [GETFDPW] = { false, &dbs[pwddb] },
   [GETFDGR] = { false, &dbs[grpdb] },
   [GETFDHST] = { false, &dbs[hstdb] },