about summary refs log tree commit diff
path: root/nptl_db
diff options
context:
space:
mode:
authorPaul E. Murphy <murphyp@linux.ibm.com>2022-06-01 16:19:49 +0000
committerPaul E. Murphy <murphyp@linux.ibm.com>2022-06-08 11:17:47 -0500
commitaa13fd16183949bbc40b010552e2e42003ebee62 (patch)
treeccd9b9e3852b5fd7f32bcf6d6db99cfa256beb14 /nptl_db
parentc2f39be490150aa748bc74d78d7ee122188a30cf (diff)
downloadglibc-aa13fd16183949bbc40b010552e2e42003ebee62.tar.gz
glibc-aa13fd16183949bbc40b010552e2e42003ebee62.tar.xz
glibc-aa13fd16183949bbc40b010552e2e42003ebee62.zip
nptl_db: disable DT_RELR on libthread_db.so
Some nptl tests inadvertently use the host's gdb to verify
libthread_db.so, which is loaded with the host's runtime.  This causes
a couple of test failures when the host glibc does not support DT_RELR.

The not correct, but simple, workaround is to build without DT_RELR
as this library is otherwise likely to load on glibc 2.17 and newer
today.

This allows tst-pthread-gdb-attach{,-static} to continue working
when testing on a gdb loaded with an older glibc.

This avoids a failure in tst-pthread-gdb-attach similar to:

  Trying host libthread_db library: .../build/glibc/nptl_db/libthread_db.so.1.
  dlopen failed: /lib64/libc.so.6: version `GLIBC_ABI_DT_RELR' not found (required by .../build/glibc/nptl_db/libthread_db.so.1).

Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Diffstat (limited to 'nptl_db')
-rw-r--r--nptl_db/Makefile6
1 files changed, 6 insertions, 0 deletions
diff --git a/nptl_db/Makefile b/nptl_db/Makefile
index ed923a41e5..2360e53c88 100644
--- a/nptl_db/Makefile
+++ b/nptl_db/Makefile
@@ -49,6 +49,12 @@ libthread_db-inhibit-o = $(filter-out .os,$(object-suffixes))
 # The ps_* callback functions are not defined.
 libthread_db.so-no-z-defs = yes
 
+# This is a hack.  This is not the correct solution.  When this glibc
+# is tested, the gdb used could be loaded by the host glibc, which
+# may not support DT_RELR, and report a failure instead of unsupported.
+# For now, build this without DT_RELR support to avoid this situation.
+libthread_db.so-no-dt-relr = yes
+
 tests-special += $(objpfx)db-symbols.out
 
 include ../Rules