about summary refs log tree commit diff
path: root/nptl
diff options
context:
space:
mode:
authorRoland McGrath <roland@gnu.org>2003-09-25 03:50:45 +0000
committerRoland McGrath <roland@gnu.org>2003-09-25 03:50:45 +0000
commit00700865648c2040c97608834076a700b2ee673f (patch)
tree922cfaeae541f6830cab13aa4c4b9cf70e9fc8d8 /nptl
parent69c9fa045bce5e125e2e4525eb62ec58965e92f5 (diff)
downloadglibc-00700865648c2040c97608834076a700b2ee673f.tar.gz
glibc-00700865648c2040c97608834076a700b2ee673f.tar.xz
glibc-00700865648c2040c97608834076a700b2ee673f.zip
2003-09-24 Roland McGrath <roland@redhat.com>
	* allocatestack.c (__make_stacks_executable): Don't ignore return
	value from _dl_make_stack_executable.
Diffstat (limited to 'nptl')
-rw-r--r--nptl/allocatestack.c19
1 files changed, 10 insertions, 9 deletions
diff --git a/nptl/allocatestack.c b/nptl/allocatestack.c
index c82b36ede0..f9600ccbd1 100644
--- a/nptl/allocatestack.c
+++ b/nptl/allocatestack.c
@@ -687,21 +687,22 @@ __make_stacks_executable (void)
   /* Also change the permission for the currently unused stacks.  This
      might be wasted time but better spend it here than adding a check
      in the fast path.  */
-  list_for_each (runp, &stack_cache)
-    {
-      err = change_stack_perm (list_entry (runp, struct pthread, list)
+  if (err == 0)
+    list_for_each (runp, &stack_cache)
+      {
+	err = change_stack_perm (list_entry (runp, struct pthread, list)
 #ifdef NEED_SEPARATE_REGISTER_STACK
-			       , pagemask
+				 , pagemask
 #endif
-			       );
-      if (err != 0)
-	break;
-    }
+				 );
+	if (err != 0)
+	  break;
+      }
 
   lll_unlock (stack_cache_lock);
 
   if (err == 0)
-    _dl_make_stack_executable ();
+    err = _dl_make_stack_executable ();
 
   return err;
 }