htl: Enable cancel*16 an cancel*20 tests

* nptl/tst-cancel16.c, tst-cancel20.c, tst-cancelx16.c, tst-cancelx20.c:
Move to...
* sysdeps/pthread: ... here.
* nptl/Makefile: Move corresponding references and rules to...
* sysdeps/pthread/Makefile: ... here.
* sysdeps/mach/hurd/i386/Makefile: Xfail tst-cancel*16 for now: missing
barrier pshared support, but test should be working otherwise.

5 files changed, 2 insertions, 507 deletions

diff --git a/nptl/Makefile b/nptl/Makefile
index 4602824bf1..5e62c77853 100644
--- a/nptl/Makefile
+++ b/nptl/Makefile
@@ -278,8 +278,7 @@ tests = tst-attr2 tst-attr3 tst-default-attr \
 	tst-sem17 \
 	tst-tsd3 tst-tsd4 \
 	tst-cancel4 tst-cancel4_1 tst-cancel4_2 tst-cancel5 \
-	tst-cancel7 \
-	tst-cancel16 tst-cancel17 tst-cancel20 tst-cancel24 \
+	tst-cancel7 tst-cancel17 tst-cancel24 \
 	tst-cleanup4 \
 	tst-signal3 \
 	tst-exec4 tst-exec5 \
@@ -357,9 +356,7 @@ endif
 
 LDFLAGS-pthread.so = -Wl,--enable-new-dtags,-z,nodelete,-z,initfirst
 
-tests += tst-cancelx4 tst-cancelx5 tst-cancelx7 \
-	 tst-cancelx16 tst-cancelx17 tst-cancelx20 \
-	 tst-cleanupx4
+tests += tst-cancelx4 tst-cancelx5 tst-cancelx7 tst-cancelx17 tst-cleanupx4
 
 ifeq ($(build-shared),yes)
 tests += tst-compat-forwarder tst-audit-threads
@@ -476,9 +473,7 @@ CFLAGS-tst-cancelx5.c += -Wno-error
 CFLAGS-tst-cancelx4.c += -fexceptions
 CFLAGS-tst-cancelx5.c += -fexceptions
 CFLAGS-tst-cancelx7.c += -fexceptions
-CFLAGS-tst-cancelx16.c += -fexceptions
 CFLAGS-tst-cancelx17.c += -fexceptions
-CFLAGS-tst-cancelx20.c += -fexceptions -fasynchronous-unwind-tables
 CFLAGS-tst-cleanupx4.c += -fexceptions
 CFLAGS-tst-cleanupx4aux.c += -fexceptions
 CFLAGS-tst-initializers1.c += -W -Wall -Werror
diff --git a/nptl/tst-cancel16.c b/nptl/tst-cancel16.c
deleted file mode 100644
index 89e033808f..0000000000
--- a/nptl/tst-cancel16.c
+++ /dev/null
@@ -1,230 +0,0 @@
-/* Copyright (C) 2003-2020 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Ulrich Drepper <drepper@redhat.com>, 2003.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <errno.h>
-#include <pthread.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <string.h>
-#include <unistd.h>
-#include <sys/mman.h>
-#include <sys/wait.h>
-
-
-static pthread_barrier_t b2;
-static int fd;
-static int called;
-
-
-static void
-cl (void *arg)
-{
-  called = 1;
-}
-
-
-static void *
-tf (void *arg)
-{
-  int r = pthread_barrier_wait (&b2);
-  if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-    {
-      puts ("child thread: barrier_wait failed");
-      exit (1);
-    }
-
-  pthread_cleanup_push (cl, NULL);
-
-  /* This call should never return.  */
-  (void) lockf (fd, F_LOCK, 0);
-
-  pthread_cleanup_pop (0);
-
-  return NULL;
-}
-
-
-static int
-do_test (void)
-{
-  char fname[] = "/tmp/cancel16XXXXXX";
-  fd = mkstemp (fname);
-  if (fd == -1)
-    {
-      puts ("mkstemp failed");
-      return 1;
-    }
-  unlink (fname);
-
-  char mem[sizeof (pthread_barrier_t)];
-  memset (mem, '\0', sizeof (mem));
-  if (TEMP_FAILURE_RETRY (pwrite (fd, mem, sizeof (mem), 0)) != sizeof (mem))
-    {
-      puts ("pwrite failed");
-      return 1;
-    }
-
-  void *p = mmap (NULL, sizeof (mem), PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
-  if (p == MAP_FAILED)
-    {
-      puts ("mmap failed");
-      return 1;
-    }
-  pthread_barrier_t *b = (pthread_barrier_t *) p;
-
-  pthread_barrierattr_t ba;
-  if (pthread_barrierattr_init (&ba) != 0)
-    {
-      puts ("barrierattr_init failed");
-      return 1;
-    }
-  if (pthread_barrierattr_setpshared (&ba, 1) != 0)
-    {
-      puts ("barrierattr_setshared failed");
-      return 1;
-    }
-
-  if (pthread_barrier_init (b, &ba, 2) != 0)
-    {
-      puts ("1st barrier_init failed");
-      return 1;
-    }
-  if (pthread_barrierattr_destroy (&ba) != 0)
-    {
-      puts ("barrier_destroy failed");
-      return 1;
-    }
-
-  pid_t pid = fork ();
-  if (pid == 0)
-    {
-      /* Child.  Lock the file and wait.  */
-      if (lockf (fd, F_LOCK, 0) != 0)
-	{
-	  puts ("child process: lockf failed");
-	  _exit (1);
-	}
-
-      int r = pthread_barrier_wait (b);
-      if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-	{
-	  puts ("child process: 1st barrier_wait failed");
-	  _exit (1);
-	}
-
-      /* Make sure the process dies.  */
-      alarm (5);
-
-      r = pthread_barrier_wait (b);
-      if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-	{
-	  puts ("child process: 2nd barrier_wait failed");
-	  _exit (1);
-	}
-
-      _exit (0);
-    }
-  if (pid == -1)
-    {
-      puts ("fork failed");
-      return 1;
-    }
-
-  int r = pthread_barrier_wait (b);
-  if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-    {
-      puts ("main: 1st barrier_wait failed");
-      _exit (1);
-    }
-
-  if (pthread_barrier_init (&b2, NULL, 2) != 0)
-    {
-      puts ("2nd barrier_init failed");
-      return 1;
-    }
-
-  pthread_t th;
-  if (pthread_create (&th, NULL, tf, NULL) != 0)
-    {
-      puts ("create failed");
-      return 1;
-    }
-
-  r = pthread_barrier_wait (&b2);
-  if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-    {
-      puts ("main: 2nd barrier_wait failed");
-      return 1;
-    }
-
-  /* Delay.  */
-  sleep (1);
-
-  if (pthread_cancel (th) != 0)
-    {
-      puts ("cancel failed");
-      return 1;
-    }
-
-  void *result;
-  if (pthread_join (th, &result) != 0)
-    {
-      puts ("join failed");
-      return 1;
-    }
-  if (result != PTHREAD_CANCELED)
-    {
-      puts ("thread not canceled");
-      return 1;
-    }
-  if (called == 0)
-    {
-      puts ("cleanup handler not called");
-      return 1;
-    }
-
-  r = pthread_barrier_wait (b);
-  if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-    {
-      puts ("main: 3rd barrier_wait failed");
-      return 1;
-    }
-
-  int status;
-  if (TEMP_FAILURE_RETRY (waitpid (pid, &status, 0)) != pid)
-    {
-      puts ("waitpid failed");
-      return 1;
-    }
-  if (WEXITSTATUS (status) != 0)
-    {
-      printf ("child process exits with %d\n", WEXITSTATUS (status));
-      return 1;
-    }
-
-  if (lockf (fd, F_LOCK, 0) != 0)
-    {
-      puts ("main: lockf failed");
-      return 1;
-    }
-
-  return 0;
-}
-
-#define TEST_FUNCTION do_test ()
-#include "../test-skeleton.c"
diff --git a/nptl/tst-cancel20.c b/nptl/tst-cancel20.c
deleted file mode 100644
index ca8badc697..0000000000
--- a/nptl/tst-cancel20.c
+++ /dev/null
@@ -1,268 +0,0 @@
-/* Copyright (C) 2003-2020 Free Software Foundation, Inc.
-   This file is part of the GNU C Library.
-   Contributed by Jakub Jelinek <jakub@redhat.com>, 2003.
-
-   The GNU C Library is free software; you can redistribute it and/or
-   modify it under the terms of the GNU Lesser General Public
-   License as published by the Free Software Foundation; either
-   version 2.1 of the License, or (at your option) any later version.
-
-   The GNU C Library is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
-   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-   Lesser General Public License for more details.
-
-   You should have received a copy of the GNU Lesser General Public
-   License along with the GNU C Library; if not, see
-   <https://www.gnu.org/licenses/>.  */
-
-#include <errno.h>
-#include <pthread.h>
-#include <signal.h>
-#include <stdio.h>
-#include <stdlib.h>
-#include <unistd.h>
-
-
-static int fd[4];
-static pthread_barrier_t b;
-volatile int in_sh_body;
-unsigned long cleanups;
-
-static void
-cl (void *arg)
-{
-  cleanups = (cleanups << 4) | (long) arg;
-}
-
-
-static void __attribute__((noinline))
-sh_body (void)
-{
-  char c;
-
-  pthread_cleanup_push (cl, (void *) 1L);
-
-  in_sh_body = 1;
-  if (read (fd[2], &c, 1) == 1)
-    {
-      puts ("read succeeded");
-      exit (1);
-    }
-
-  pthread_cleanup_pop (0);
-}
-
-
-static void
-sh (int sig)
-{
-  pthread_cleanup_push (cl, (void *) 2L);
-  sh_body ();
-  in_sh_body = 0;
-
-  pthread_cleanup_pop (0);
-}
-
-
-static void __attribute__((noinline))
-tf_body (void)
-{
-  char c;
-
-  pthread_cleanup_push (cl, (void *) 3L);
-
-  int r = pthread_barrier_wait (&b);
-  if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-    {
-      puts ("child thread: barrier_wait failed");
-      exit (1);
-    }
-
-  if (read (fd[0], &c, 1) == 1)
-    {
-      puts ("read succeeded");
-      exit (1);
-    }
-
-  read (fd[0], &c, 1);
-
-  pthread_cleanup_pop (0);
-}
-
-
-static void *
-tf (void *arg)
-{
-  pthread_cleanup_push (cl, (void *) 4L);
-  tf_body ();
-  pthread_cleanup_pop (0);
-  return NULL;
-}
-
-
-static int
-do_one_test (void)
-{
-  in_sh_body = 0;
-  cleanups = 0;
-  if (pipe (fd) != 0 || pipe (fd + 2) != 0)
-    {
-      puts ("pipe failed");
-      return 1;
-    }
-
-  pthread_t th;
-  if (pthread_create (&th, NULL, tf, NULL) != 0)
-    {
-      puts ("create failed");
-      return 1;
-    }
-
-  int r = pthread_barrier_wait (&b);
-  if (r != 0 && r != PTHREAD_BARRIER_SERIAL_THREAD)
-    {
-      puts ("parent thread: barrier_wait failed");
-      return 1;
-    }
-
-  sleep (1);
-
-  r = pthread_kill (th, SIGHUP);
-  if (r)
-    {
-      errno = r;
-      printf ("pthread_kill failed %m\n");
-      return 1;
-    }
-
-  while (in_sh_body == 0)
-    sleep (1);
-
-  if (pthread_cancel (th) != 0)
-    {
-      puts ("cancel failed");
-      return 1;
-    }
-
-  void *ret;
-  if (pthread_join (th, &ret) != 0)
-    {
-      puts ("join failed");
-      return 1;
-    }
-
-  if (ret != PTHREAD_CANCELED)
-    {
-      puts ("result is wrong");
-      return 1;
-    }
-
-  if (cleanups != 0x1234L)
-    {
-      printf ("called cleanups %lx\n", cleanups);
-      return 1;
-    }
-
-  /* The pipe closing must be issued after the cancellation handling to avoid
-     a race condition where the cancellation runs after both pipe ends are
-     closed.  In this case the read syscall returns EOF and the cancellation
-     must not act.  */
-  close (fd[0]);
-  close (fd[1]);
-  close (fd[2]);
-  close (fd[3]);
-
-  return 0;
-}
-
-
-static int
-do_test (void)
-{
-  stack_t ss;
-  ss.ss_sp = malloc (2 * SIGSTKSZ);
-  if (ss.ss_sp == NULL)
-    {
-      puts ("failed to allocate alternate stack");
-      return 1;
-    }
-  ss.ss_flags = 0;
-  ss.ss_size = 2 * SIGSTKSZ;
-  if (sigaltstack (&ss, NULL) < 0)
-    {
-      printf ("sigaltstack failed %m\n");
-      return 1;
-    }
-
-  if (pthread_barrier_init (&b, NULL, 2) != 0)
-    {
-      puts ("barrier_init failed");
-      return 1;
-    }
-
-  struct sigaction sa;
-  sa.sa_handler = sh;
-  sigemptyset (&sa.sa_mask);
-  sa.sa_flags = 0;
-
-  if (sigaction (SIGHUP, &sa, NULL) != 0)
-    {
-      puts ("sigaction failed");
-      return 1;
-    }
-
-  puts ("sa_flags = 0 test");
-  if (do_one_test ())
-    return 1;
-
-  sa.sa_handler = sh;
-  sigemptyset (&sa.sa_mask);
-  sa.sa_flags = SA_ONSTACK;
-
-  if (sigaction (SIGHUP, &sa, NULL) != 0)
-    {
-      puts ("sigaction failed");
-      return 1;
-    }
-
-  puts ("sa_flags = SA_ONSTACK test");
-  if (do_one_test ())
-    return 1;
-
-#ifdef SA_SIGINFO
-  sa.sa_sigaction = (void (*)(int, siginfo_t *, void *)) sh;
-  sigemptyset (&sa.sa_mask);
-  sa.sa_flags = SA_SIGINFO;
-
-  if (sigaction (SIGHUP, &sa, NULL) != 0)
-    {
-      puts ("sigaction failed");
-      return 1;
-    }
-
-  puts ("sa_flags = SA_SIGINFO test");
-  if (do_one_test ())
-    return 1;
-
-  sa.sa_sigaction = (void (*)(int, siginfo_t *, void *)) sh;
-  sigemptyset (&sa.sa_mask);
-  sa.sa_flags = SA_SIGINFO | SA_ONSTACK;
-
-  if (sigaction (SIGHUP, &sa, NULL) != 0)
-    {
-      puts ("sigaction failed");
-      return 1;
-    }
-
-  puts ("sa_flags = SA_SIGINFO|SA_ONSTACK test");
-  if (do_one_test ())
-    return 1;
-#endif
-
-  return 0;
-}
-
-#define TIMEOUT 40
-#define TEST_FUNCTION do_test ()
-#include "../test-skeleton.c"
diff --git a/nptl/tst-cancelx16.c b/nptl/tst-cancelx16.c
deleted file mode 100644
index 99af3b197c..0000000000
--- a/nptl/tst-cancelx16.c
+++ /dev/null
@@ -1 +0,0 @@
-#include "tst-cancel16.c"
diff --git a/nptl/tst-cancelx20.c b/nptl/tst-cancelx20.c
deleted file mode 100644
index 6bd86376ca..0000000000
--- a/nptl/tst-cancelx20.c
+++ /dev/null
@@ -1 +0,0 @@
-#include "tst-cancel20.c"