diff options
| author | Florian Weimer <fweimer@redhat.com> | 2021-02-03 08:55:13 -0300 |
|---|---|---|
| committer | Adhemerval Zanella <adhemerval.zanella@linaro.org> | 2021-02-08 14:10:42 -0300 |
| commit | e9fed2438a1ff475821864f906286dc58907f06b (patch) | |
| tree | 185b4a49e256ef312e65eafebf836ba17ea2ccef /nptl | |
| parent | 7f61f785f16d22f185de77086c44a88218436cfb (diff) | |
| download | glibc-e9fed2438a1ff475821864f906286dc58907f06b.tar.gz glibc-e9fed2438a1ff475821864f906286dc58907f06b.tar.xz glibc-e9fed2438a1ff475821864f906286dc58907f06b.zip | |
linux: Require /dev/shm as the shared memory file system
Previously, glibc would pick an arbitrary tmpfs file system from /proc/mounts if /dev/shm was not available. This could lead to an unsuitable file system being picked for the backing storage for shm_open, sem_open, and related functions. This patch introduces a new function, __shm_get_name, which builds the file name under the appropriate (now hard-coded) directory. It is called from the various shm_* and sem_* function. Unlike the SHM_GET_NAME macro it replaces, the callers handle the return values and errno updates. shm-directory.c is moved directly into the posix subdirectory because it can be implemented directly using POSIX functionality. It resides in libc because it is needed by both librt and nptl/htl. In the sem_open implementation, tmpfname is initialized directly from a string constant. This happens to remove one alloca call. Checked on x86_64-linux-gnu.
Diffstat (limited to 'nptl')
| -rw-r--r-- | nptl/Makefile | 1 | ||||
| -rw-r--r-- | nptl/Versions | 1 | ||||
| -rw-r--r-- | nptl/nptlfreeres.c | 1 | ||||
| -rw-r--r-- | nptl/pthreadP.h | 1 |
4 files changed, 0 insertions, 4 deletions
diff --git a/nptl/Makefile b/nptl/Makefile index 0282e07390..c49134b936 100644 --- a/nptl/Makefile +++ b/nptl/Makefile @@ -137,7 +137,6 @@ libpthread-routines = nptl-init nptlfreeres vars events version pt-interp \ pthread_once \ old_pthread_atfork \ pthread_getcpuclockid \ - shm-directory \ sem_init sem_destroy \ sem_open sem_close sem_unlink \ sem_getvalue \ diff --git a/nptl/Versions b/nptl/Versions index 02650fe91c..5db713d1ae 100644 --- a/nptl/Versions +++ b/nptl/Versions @@ -303,7 +303,6 @@ libpthread { __pthread_unwind; __pthread_get_minstack; __pthread_barrier_init; __pthread_barrier_wait; __futex_abstimed_wait64; __futex_abstimed_wait_cancelable64; - __shm_directory; __libpthread_freeres; } } diff --git a/nptl/nptlfreeres.c b/nptl/nptlfreeres.c index 77ad5b53ff..d295bcb3c3 100644 --- a/nptl/nptlfreeres.c +++ b/nptl/nptlfreeres.c @@ -27,6 +27,5 @@ __libpthread_freeres (void) { call_function_static_weak (__default_pthread_attr_freeres); call_function_static_weak (__nptl_stacks_freeres); - call_function_static_weak (__shm_directory_freeres); call_function_static_weak (__nptl_unwind_freeres); } diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h index e5efa2e62d..d078128230 100644 --- a/nptl/pthreadP.h +++ b/nptl/pthreadP.h @@ -629,7 +629,6 @@ extern void __nptl_set_robust (struct pthread *self); #endif extern void __nptl_stacks_freeres (void) attribute_hidden; -extern void __shm_directory_freeres (void) attribute_hidden; extern void __wait_lookup_done (void) attribute_hidden; |