about summary refs log tree commit diff
path: root/nptl
diff options
context:
space:
mode:
authorFrédéric Bérat <fberat@redhat.com>2023-06-14 10:52:07 +0200
committerSiddhesh Poyarekar <siddhesh@sourceware.org>2023-06-19 09:15:05 -0400
commit8022fc7d5119a22e9e0ac72798f649385b0e167a (patch)
treef2cdb5c88d14c05e96395f0cdc99a6692ec0f8da /nptl
parent20b6b8e8a50874dd189687df8f6f8a11d4813b34 (diff)
downloadglibc-8022fc7d5119a22e9e0ac72798f649385b0e167a.tar.gz
glibc-8022fc7d5119a22e9e0ac72798f649385b0e167a.tar.xz
glibc-8022fc7d5119a22e9e0ac72798f649385b0e167a.zip
tests: replace system by xsystem
With fortification enabled, system calls return result needs to be checked,
has it gets the __wur macro enabled.
Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
Diffstat (limited to 'nptl')
-rw-r--r--nptl/tst-cancel7.c3
-rw-r--r--nptl/tst-stackguard1.c4
2 files changed, 5 insertions, 2 deletions
diff --git a/nptl/tst-cancel7.c b/nptl/tst-cancel7.c
index 2835613a9b..ef9e11ce58 100644
--- a/nptl/tst-cancel7.c
+++ b/nptl/tst-cancel7.c
@@ -43,7 +43,8 @@ tf (void *arg)
 {
   char *cmd = xasprintf ("%s --direct --sem %s --pidfile %s",
 			 command, semfilename, pidfilename);
-  system (cmd);
+  if (system (cmd))
+    FAIL_EXIT1("system call unexpectedly returned");
   /* This call should never return.  */
   return NULL;
 }
diff --git a/nptl/tst-stackguard1.c b/nptl/tst-stackguard1.c
index 4ac57157e9..7308b9d37a 100644
--- a/nptl/tst-stackguard1.c
+++ b/nptl/tst-stackguard1.c
@@ -28,6 +28,7 @@
 #include <unistd.h>
 
 #include <support/xunistd.h>
+#include <support/xstdlib.h>
 
 static const char *command;
 static bool child;
@@ -140,7 +141,8 @@ do_test (void)
 	  dup2 (fds[1], 2);
 	  close (fds[1]);
 
-	  system (command);
+	  xsystem (command);
+
 	  exit (0);
 	}