about summary refs log tree commit diff
path: root/nptl/nptl-init.c
diff options
context:
space:
mode:
authorSzabolcs Nagy <szabolcs.nagy@arm.com>2017-12-06 13:05:50 +0000
committerSzabolcs Nagy <szabolcs.nagy@arm.com>2018-01-08 19:02:11 +0000
commit630f4cc3aa019ede55976ea561f1a7af2f068639 (patch)
tree67f9cc70df8a9b90122106ec5be5ac7495f00dda /nptl/nptl-init.c
parentc70e4e9c9efff9df4c847dd7cfd81bae674219ab (diff)
downloadglibc-630f4cc3aa019ede55976ea561f1a7af2f068639.tar.gz
glibc-630f4cc3aa019ede55976ea561f1a7af2f068639.tar.xz
glibc-630f4cc3aa019ede55976ea561f1a7af2f068639.zip
[BZ #22637] Fix stack guard size accounting
Previously if user requested S stack and G guard when creating a
thread, the total mapping was S and the actual available stack was
S - G - static_tls, which is not what the user requested.

This patch fixes the guard size accounting by pretending the user
requested S+G stack.  This way all later logic works out except
when reporting the user requested stack size (pthread_getattr_np)
or when computing the minimal stack size (__pthread_get_minstack).

Normally this will increase thread stack allocations by one page.
TLS accounting is not affected, that will require a separate fix.

	[BZ #22637]
	* nptl/descr.h (stackblock, stackblock_size): Update comments.
	* nptl/allocatestack.c (allocate_stack): Add guardsize to stacksize.
	* nptl/nptl-init.c (__pthread_get_minstack): Remove guardsize from
	stacksize.
	* nptl/pthread_getattr_np.c (pthread_getattr_np): Likewise.
Diffstat (limited to 'nptl/nptl-init.c')
-rw-r--r--nptl/nptl-init.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/nptl/nptl-init.c b/nptl/nptl-init.c
index c237a3675a..5a4b52419f 100644
--- a/nptl/nptl-init.c
+++ b/nptl/nptl-init.c
@@ -472,8 +472,5 @@ strong_alias (__pthread_initialize_minimal_internal,
 size_t
 __pthread_get_minstack (const pthread_attr_t *attr)
 {
-  struct pthread_attr *iattr = (struct pthread_attr *) attr;
-
-  return (GLRO(dl_pagesize) + __static_tls_size + PTHREAD_STACK_MIN
-	  + iattr->guardsize);
+  return GLRO(dl_pagesize) + __static_tls_size + PTHREAD_STACK_MIN;
 }