about summary refs log tree commit diff
path: root/misc
diff options
context:
space:
mode:
authorZack Weinberg <zackw@panix.com>2019-08-16 21:10:11 -0400
committerZack Weinberg <zackw@panix.com>2019-08-21 08:26:36 -0400
commit1baae4aa6f3313da77d799f12f963910b05db637 (patch)
tree8e355e8254a1e5f93b381f552ab5e95a3dd64fcf /misc
parentf9fabc1b02d252d5d9b2e0df406bb394b8a7b46a (diff)
downloadglibc-1baae4aa6f3313da77d799f12f963910b05db637.tar.gz
glibc-1baae4aa6f3313da77d799f12f963910b05db637.tar.xz
glibc-1baae4aa6f3313da77d799f12f963910b05db637.zip
Don't use the argument to time.
It doesn't make sense to remove all the internal uses of time.
It's still a standard ISO C function, and its callers don't need
sub-second resolution and would be unnecessarily complicated if
they had to declare a struct timespec instead of just a time_t.
However, a handful of places were using the vestigial "result"
argument instead of the return value, which is slightly less
efficient and also looks strange.  Correct this.

	* misc/syslog.c (__vsyslog_internal)
	* time/getdate.c (__getdate_r)
	* time/tst_wcsftime.c (main):
	Use return value of time, not its argument.

	* string/strfry.c (strfry)
	* sysdeps/mach/sleep.c (__sleep):
	Remove unnecessary casts of NULL in calls to time.
Diffstat (limited to 'misc')
-rw-r--r--misc/syslog.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/misc/syslog.c b/misc/syslog.c
index 3a15da41ce..cf2deef533 100644
--- a/misc/syslog.c
+++ b/misc/syslog.c
@@ -205,7 +205,7 @@ __vsyslog_internal(int pri, const char *fmt, va_list ap,
 	  {
 	    __fsetlocking (f, FSETLOCKING_BYCALLER);
 	    fprintf (f, "<%d>", pri);
-	    (void) time (&now);
+	    now = time (NULL);
 	    f->_IO_write_ptr += __strftime_l (f->_IO_write_ptr,
 					      f->_IO_write_end
 					      - f->_IO_write_ptr,