diff options
| author | Gabriel F. T. Gomes <gabrielftg@linux.ibm.com> | 2019-07-11 11:48:24 -0300 |
|---|---|---|
| committer | Gabriel F. T. Gomes <gabrielftg@linux.ibm.com> | 2019-12-23 16:32:20 -0300 |
| commit | 3021e781783d6fe12de4697b0d98957bc911cad3 (patch) | |
| tree | e2160e9c74cc5343f69b42cf6a1ee3f5fad9a11e /misc | |
| parent | dce425341171ec5784c87165e23883630971bd97 (diff) | |
| download | glibc-3021e781783d6fe12de4697b0d98957bc911cad3.tar.gz glibc-3021e781783d6fe12de4697b0d98957bc911cad3.tar.xz glibc-3021e781783d6fe12de4697b0d98957bc911cad3.zip | |
ldbl-128ibm-compat: Add *cvt functions
This patch adds IEEE long double versions of q*cvt* functions for
powerpc64le. Unlike all other long double to/from string conversion
functions, these do not rely on internal functions that can take
floating-point numbers with different formats and act on them
accordingly, instead, the related files are rebuilt with the
-mabi=ieeelongdouble compiler flag set.
Having -mabi=ieeelongdouble passed to the compiler causes the object
files to be marked with a .gnu_attribute that is incompatible with the
.gnu_attribute in files built with -mabi=ibmlongdouble (the default).
The difference causes error messages similar to the following:
ld: libc_pic.a(s_isinfl.os) uses IBM long double,
libc_pic.a(ieee128-qefgcvt_r.os) uses IEEE long double.
collect2: error: ld returned 1 exit status
make[2]: *** [../Makerules:649: libc_pic.os] Error 1
Although this warning is useful in other situations, the library
actually needs to have functions with different long double formats, so
.gnu_attribute generation is explicitly disabled for these files with
the use of -mno-gnu-attribute.
Tested for powerpc64le on the branch that actually enables the
sysdeps/ieee754/ldbl-128ibm-compat for powerpc64le.
Reviewed-by: Paul E. Murphy <murphyp@linux.ibm.com>
Diffstat (limited to 'misc')
| -rw-r--r-- | misc/efgcvt-template.c | 6 | ||||
| -rw-r--r-- | misc/efgcvt_r-template.c | 6 |
2 files changed, 10 insertions, 2 deletions
diff --git a/misc/efgcvt-template.c b/misc/efgcvt-template.c index 7fabdf264d..fe4c28bf0f 100644 --- a/misc/efgcvt-template.c +++ b/misc/efgcvt-template.c @@ -23,6 +23,10 @@ #include <libc-lock.h> #include <math_ldbl_opt.h> +#ifndef SPRINTF +# define SPRINTF sprintf +#endif + #define APPEND(a, b) APPEND2 (a, b) #define APPEND2(a, b) a##b @@ -66,6 +70,6 @@ __ECVT (FLOAT_TYPE value, int ndigit, int *decpt, int *sign) char * __GCVT (FLOAT_TYPE value, int ndigit, char *buf) { - sprintf (buf, "%.*" FLOAT_FMT_FLAG "g", MIN (ndigit, NDIGIT_MAX), value); + SPRINTF (buf, "%.*" FLOAT_FMT_FLAG "g", MIN (ndigit, NDIGIT_MAX), value); return buf; } diff --git a/misc/efgcvt_r-template.c b/misc/efgcvt_r-template.c index 977750118c..bae2d30a77 100644 --- a/misc/efgcvt_r-template.c +++ b/misc/efgcvt_r-template.c @@ -25,6 +25,10 @@ #include <sys/param.h> #include <math_ldbl_opt.h> +#ifndef SNPRINTF +# define SNPRINTF __snprintf +#endif + #define APPEND(a, b) APPEND2 (a, b) #define APPEND2(a, b) a##b @@ -73,7 +77,7 @@ __FCVT_R (FLOAT_TYPE value, int ndigit, int *decpt, int *sign, /* Value is Inf or NaN. */ *sign = 0; - n = __snprintf (buf, len, "%.*" FLOAT_FMT_FLAG "f", MIN (ndigit, NDIGIT_MAX), + n = SNPRINTF (buf, len, "%.*" FLOAT_FMT_FLAG "f", MIN (ndigit, NDIGIT_MAX), value); /* Check for a too small buffer. */ if (n >= (ssize_t) len) |